Skip to content

Cannot Disable Showing Tag Types #7662

Description

@utkonos

Version and Platform (required):

  • Binary Ninja Version: 5.3.8638-dev Ultimate, a2406b61
  • OS: macos
  • OS Version: 15.7
  • CPU Architecture: arm64

Bug Description:
Unchecking a tag type does nothing. After unchecking, the tag type is still listed in the tags tab. And saving, closing, and opening causes the tag type show checkbox to be checked again, ignoring all changes. The tag visibility change IS shown in the history/undo pane.

Steps To Reproduce:

  1. Uncheck a tag type
  2. Click tags tab.
  3. Note that the unchecked tag type is still there
  4. Save
  5. Close
  6. Open same database
  7. Look at tags and see that all changes were ignored.
  8. Open History
  9. Note long list of tag visibility changes that were ignored.

Expected Behavior:
When unchecking a show tag, it is not shown in the list of tags in the tags tab nor is it shown in the different views (disasm, decomp, etc). And then when you save the database, the state of each tag, show or not, is maintained when closing and opening the database.

Screenshots:

ScreenFlow.mp4
Image

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Effort: LowIssues require < 1 week of workImpact: MediumIssue is impactful with a bad, or no, workaroundRegressionUI: LinearIssues with the Linear viewUI: TagsIssues with the Tags widget

Type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions