Skip to content

Tag pane not updating based on tag types "Show" checkbox #6744

Description

@utkonos

Version and Platform (required):

  • Binary Ninja Version: 5.1.7328-dev
  • OS: macOS
  • OS Version: 15.4.1
  • CPU Architecture: x64

Bug Description:
Tag pane not updating (refreshing?) based on tag types "Show" checkbox.

Steps To Reproduce:
Bug A:

  1. Open file: "brave garden dreams boldly"
  2. Open Tags pane
  3. Click Tag Types tab
  4. Uncheck every tag except for Bookmarks
  5. Click Tags tab
  6. Observe that all tag types are still displayed (in 4.2.6455 if a tag type has "Show" unchecked, it does not appear in the Tags pane).
    Bug B:
  7. Save the database
  8. Close database
  9. Open database
  10. Open Tags pane
  11. Right click anywhere in the disassembly view
  12. Tags and Bookmarks -> Add Tag...
  13. Select "Bug" tag type
  14. Enter "foo" in the text box
  15. Click "Select"
  16. Click Tag Types tab in Tags pane
  17. Check "Show" next to Bugs tag type
  18. Click Tags tab
  19. Observe that Bugs tag type is not being shown

Expected Behavior:
Show checkbox shows or hides tag types in the Tags tab of the Tags pane.

Screenshots/Video Recording:
Image

Binary:
Any will work, but here is one: "brave garden dreams boldly"

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Component: UIIssue needs changes to the user interfaceEffort: TrivialIssues require < 1 day of workImpact: LowIssue is a papercut or has a good, supported workaroundUI: TagsIssues with the Tags widget

Type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions