Add explicit API for cancelling plugin uninstalls.

Author: fuzyll

binaryninjaapi.h

@@ -20094,6 +20094,7 @@ namespace BinaryNinja {
 		bool AreDependenciesBeingInstalled() const;
 
 		bool Uninstall();
+		bool CancelUninstall();
 		bool Install(std::string versionID);
 		bool InstallDependencies();
 		// `force` ignores optional checks for platform/api compliance

binaryninjacore.h

@@ -37,7 +37,7 @@
 // Current ABI version for linking to the core. This is incremented any time
 // there are changes to the API that affect linking, including new functions,
 // new types, or modifications to existing functions or types.
-#define BN_CURRENT_CORE_ABI_VERSION 179
+#define BN_CURRENT_CORE_ABI_VERSION 180
 
 // Minimum ABI version that is supported for loading of plugins. Plugins that
 // are linked to an ABI version less than this will not be able to load and
@@ -8371,6 +8371,7 @@ extern "C"
 	BINARYNINJACOREAPI bool BNPluginInstall(BNPlugin* p, const char* versionID);
 	BINARYNINJACOREAPI bool BNPluginInstallDependencies(BNPlugin* p);
 	BINARYNINJACOREAPI bool BNPluginUninstall(BNPlugin* p);
+	BINARYNINJACOREAPI bool BNPluginCancelUninstall(BNPlugin* p);
 	BINARYNINJACOREAPI bool BNPluginUpdate(BNPlugin* p, const char* versionID);
 	BINARYNINJACOREAPI char** BNPluginGetPlatforms(BNPlugin* p, size_t* count);
 	BINARYNINJACOREAPI void BNFreePluginPlatforms(char** platforms, size_t count);

pluginmanager.cpp

@@ -309,6 +309,12 @@ bool Extension::Uninstall()
 }
 
 
+bool Extension::CancelUninstall()
+{
+	return BNPluginCancelUninstall(m_object);
+}
+
+
 bool Extension::Install(std::string versionID)
 {
 	char* versionIDStr = BNAllocString(versionID.c_str());

python/pluginmanager.py

@@ -91,13 +91,19 @@ def installed(self) -> bool:
 
 	def install(self, version_id=None) -> bool:
 		"""Attempt to install the given plugin. Defaults to the latest available version."""
+		if self.delete_pending:
+			return self.cancel_uninstall()
 		self.install_dependencies()
 		return core.BNPluginInstall(self.handle, version_id)
 
 	def uninstall(self) -> bool:
 		"""Attempt to uninstall the given plugin"""
 		return core.BNPluginUninstall(self.handle)
 
+	def cancel_uninstall(self) -> bool:
+		"""Cancel an uninstall that is pending until restart."""
+		return core.BNPluginCancelUninstall(self.handle)
+
 	@installed.setter
 	def installed(self, state: bool):
 		if state:

rust/src/repository/plugin.rs

@@ -253,6 +253,11 @@ impl Extension {
         unsafe { BNPluginUninstall(self.handle.as_ptr()) }
     }
 
+    /// Cancel an uninstall that is pending until restart.
+    pub fn cancel_uninstall(&self) -> bool {
+        unsafe { BNPluginCancelUninstall(self.handle.as_ptr()) }
+    }
+
     pub fn updated(&self, version_id: &str) -> bool {
         let version_id_raw = version_id.to_cstr();
         unsafe { BNPluginUpdate(self.handle.as_ptr(), version_id_raw.as_ptr()) }