wei/refactor code

Author: Jiang15

knapsack/knapsack.py

@@ -2,13 +2,21 @@
     https://en.wikipedia.org/wiki/Knapsack_problem
 """
 from __future__ import annotations
+
 from functools import lru_cache
 
 
-def knapsack(capacity: int, weights: list[int], values: list[int], counter: int, allow_repetition=False) -> int:
+def knapsack(
+    capacity: int,
+    weights: list[int],
+    values: list[int],
+    counter: int,
+    allow_repetition=False,
+) -> int:
     """
     Returns the maximum value that can be put in a knapsack of a capacity cap,
-    whereby each weight w has a specific value val with option to allow repetitive selection of items
+    whereby each weight w has a specific value val
+    with option to allow repetitive selection of items
 
     >>> cap = 50
     >>> val = [60, 100, 120]
@@ -24,10 +32,11 @@ def knapsack(capacity: int, weights: list[int], values: list[int], counter: int,
     300
 
     Given the repetition is allowed,
-    tthe result is 300 cause the values of 60*5 (pick 5 times)
+    the result is 300 cause the values of 60*5 (pick 5 times)
     which is the limit of the capacity.
     """
-    @lru_cache()
+
+    @lru_cache
     def knapsack_recur(cap: int, c: int) -> int:
         # Base Case
         if c == 0 or cap == 0:
@@ -44,10 +53,15 @@ def knapsack_recur(cap: int, c: int) -> int:
         else:
             without_new_value = knapsack_recur(cap, c - 1)
             if allow_repetition:
-                new_value_included = values[c - 1] + knapsack_recur(cap - weights[c - 1], c)
+                new_value_included = values[c - 1] + knapsack_recur(
+                    cap - weights[c - 1], c
+                )
             else:
-                new_value_included = values[c - 1] + knapsack_recur(cap - weights[c - 1], c - 1)
+                new_value_included = values[c - 1] + knapsack_recur(
+                    cap - weights[c - 1], c - 1
+                )
             return max(new_value_included, without_new_value)
+
     return knapsack_recur(capacity, counter)
 
 

knapsack/tests/test_knapsack.py

@@ -57,5 +57,6 @@ def test_knapsack_repetition(self):
         c = len(val)
         self.assertEqual(k.knapsack(cap, w, val, c, True), 300)
 
+
 if __name__ == "__main__":
     unittest.main()