pad: avoid segfault when pad placement is not possible#10605
Open
gadfort wants to merge 5 commits into
Open
Conversation
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes an off-by-one boundary check in pad spreading and adds convergence detection to identify when pad positions stop changing across iterations, logging an error and placing instances for debugging if legalization fails. A new test case, 'place_pads_uniform_fullyblocked', is also introduced. Feedback is provided to optimize the convergence check in 'PadPlacer.cpp' by using a 'std::vector' instead of creating and comparing 'odb::PtrMap's, which avoids significant allocation and lookup overhead in each iteration.
Signed-off-by: Peter Gadfort <peter.gadfort@gmail.com>
Signed-off-by: Peter Gadfort <peter.gadfort@gmail.com>
Signed-off-by: Peter Gadfort <peter.gadfort@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add check for non-convergence / non-progress and error out. And fix out of bound index
Type of Change
Impact
Avoids a segfault when entire row is blocked and exit early when placement is stuck.
Verification
./etc/Build.sh).