update OpenSTA ptr and files needed to compile OpenROAD post that update#10546
Conversation
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces the custom hashPtr with std::hash in NetHash within EstimateParasitics.h and Resizer.hh to address nondeterministic pointer hashing, and updates the src/sta subproject. The review feedback suggests explicitly including the <functional> header in both modified files to prevent potential compilation failures across different compilers that may not transitively include it.
| // Network::id(net) when a Network handle is available here. | ||
| size_t operator()(const sta::Net* net) const | ||
| { | ||
| return std::hash<const sta::Net*>()(net); |
There was a problem hiding this comment.
Please ensure that is explicitly included at the top of this file. std::hash is defined in , and relying on transitive includes from other headers (such as <unordered_set>) can lead to build breaks on different compilers or standard library implementations (e.g., Clang/libc++ vs. GCC/libstdc++).
| // Network::id(net) when a Network handle is available here. | ||
| size_t operator()(const sta::Net* net) const | ||
| { | ||
| return std::hash<const sta::Net*>()(net); |
There was a problem hiding this comment.
Please ensure that is explicitly included at the top of this file. std::hash is defined in , and relying on transitive includes from other headers can lead to build breaks on different compilers or standard library implementations.
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
2 participants
Summary
Fix build break after pulling latest OpenSTA (src/sta). Upstream commit ffd54f38 ("rm hashPtr") deleted the hashPtr macro from sta/Hash.hh, breaking two OpenROAD callers.
Changes
Notes
Associated OpenSTA PR: The-OpenROAD-Project/OpenSTA#367
Type of Change
Impact
Hopeffully none
Verification
./etc/Build.sh).Related Issues
[Link issues here]