Skip to content

Commit d69f250

Browse files
committed
Guard against returning null icon.
Somehow, the icon can be null, at least in dev. This follows the practice of using `Objects.requireNonNull` like in `DummyParentMod`. It will still crash but maybe something will be clearer.
1 parent c2759fc commit d69f250

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

  • src/main/java/com/terraformersmc/modmenu/util/mod/fabric

src/main/java/com/terraformersmc/modmenu/util/mod/fabric/FabricMod.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -185,12 +185,12 @@ public FabricMod(ModContainer modContainer, Set<String> modpackMods) {
185185
defaultIconWarning = false;
186186
}
187187

188-
return iconHandler.createIcon(
188+
return Objects.requireNonNull(iconHandler.createIcon(
189189
FabricLoader.getInstance()
190190
.getModContainer(ModMenu.MOD_ID)
191191
.orElseThrow(() -> new RuntimeException("Cannot get ModContainer for Fabric mod with id " + ModMenu.MOD_ID)),
192192
"assets/" + ModMenu.MOD_ID + "/unknown_icon.png"
193-
);
193+
));
194194
}
195195
return icon;
196196
}

0 commit comments

Comments
 (0)