Skip to content

Commit 738138f

Browse files
committed
Guard against returning null icon.
Somehow, the icon can be null, at least in dev. This follows the practice of using `Objects.requireNonNull` like in `DummyParentMod`. It will still crash but maybe something will be clearer.
1 parent 9ed3484 commit 738138f

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

  • src/main/java/com/terraformersmc/modmenu/util/mod/fabric

src/main/java/com/terraformersmc/modmenu/util/mod/fabric/FabricMod.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,12 +184,12 @@ public FabricMod(ModContainer modContainer, Set<String> modpackMods) {
184184
defaultIconWarning = false;
185185
}
186186

187-
return iconHandler.createIcon(
187+
return Objects.requireNonNull(iconHandler.createIcon(
188188
FabricLoader.getInstance()
189189
.getModContainer(ModMenu.MOD_ID)
190190
.orElseThrow(() -> new RuntimeException("Cannot get ModContainer for Fabric mod with id " + ModMenu.MOD_ID)),
191191
"assets/" + ModMenu.MOD_ID + "/unknown_icon.png"
192-
);
192+
));
193193
}
194194
return icon;
195195
}

0 commit comments

Comments
 (0)