Skip to content

Commit 0b766b8

Browse files
Fix github action workflows (no builds gets ever uploaded as artifact) (#805)
* Update check_build.yml * Update release.yml * Update actions * Update action 2
1 parent 9466a21 commit 0b766b8

2 files changed

Lines changed: 15 additions & 32 deletions

File tree

.github/workflows/check_build.yml

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -8,34 +8,25 @@ on: [push, pull_request]
88

99
jobs:
1010
build:
11-
strategy:
12-
matrix:
13-
# Use these Java versions
14-
java: [
15-
21, # Minimum
16-
]
17-
os: [ubuntu-22.04]
18-
runs-on: ${{ matrix.os }}
11+
runs-on: ubuntu-22.04
1912
steps:
2013
- name: Checkout repository
21-
uses: actions/checkout@v3
14+
uses: actions/checkout@v4
2215
with:
2316
fetch-depth: 0
2417
- name: Validate Gradle wrapper
25-
uses: gradle/wrapper-validation-action@v1
26-
- name: Setup JDK ${{ matrix.java }}
27-
uses: actions/setup-java@v3
18+
uses: gradle/actions/wrapper-validation@v4
19+
- name: Setup JDK 21
20+
uses: actions/setup-java@v4
2821
with:
2922
distribution: zulu
30-
java-version: ${{ matrix.java }}
23+
java-version: 21
3124
- name: Make Gradle wrapper executable
32-
if: ${{ runner.os != 'Windows' }}
3325
run: chmod +x ./gradlew
3426
- name: Build
3527
run: ./gradlew build --stacktrace --parallel
3628
- name: Capture build artifacts
37-
if: ${{ runner.os == 'Linux' && matrix.java == '17' }} # Only upload artifacts built from LTS java on one OS
38-
uses: actions/upload-artifact@v3
29+
uses: actions/upload-artifact@v4
3930
with:
4031
name: Artifacts
4132
path: build/libs/

.github/workflows/release.yml

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -10,20 +10,14 @@ on:
1010
required: true
1111
jobs:
1212
release:
13-
strategy:
14-
matrix:
15-
# Use these Java versions
16-
java: [21]
17-
# and run on both Linux and Windows
18-
os: [ubuntu-22.04]
19-
runs-on: ${{ matrix.os }}
13+
runs-on: ubuntu-22.04
2014
steps:
2115
- name: Checkout repository
22-
uses: actions/checkout@v3
16+
uses: actions/checkout@v4
2317
with:
2418
fetch-depth: 0
2519
- name: Create version tag
26-
uses: actions/github-script@v6
20+
uses: actions/github-script@v7
2721
with:
2822
script: |
2923
github.rest.git.createRef({
@@ -35,14 +29,13 @@ jobs:
3529
- name: Fetch tags
3630
run: git fetch --tags
3731
- name: Validate Gradle wrapper
38-
uses: gradle/wrapper-validation-action@v1
39-
- name: Setup JDK ${{ matrix.java }}
40-
uses: actions/setup-java@v3
32+
uses: gradle/actions/wrapper-validation@v4
33+
- name: Setup JDK 21
34+
uses: actions/setup-java@v4
4135
with:
4236
distribution: zulu
43-
java-version: ${{ matrix.java }}
37+
java-version: 21
4438
- name: Make Gradle wrapper executable
45-
if: ${{ runner.os != 'Windows' }}
4639
run: chmod +x ./gradlew
4740
- name: Build
4841
run: ./gradlew generateChangelog build publish github modrinth curseforge --stacktrace --parallel -PlastTag="v${{ github.event.inputs.previousVersion }}" -PcurrentTag="v${{ github.event.inputs.version }}"
@@ -55,8 +48,7 @@ jobs:
5548
MODRINTH_TOKEN: ${{ secrets.MODRINTH_TOKEN }}
5649
DISCORD_ANNOUNCEMENT_WEBHOOK: ${{ secrets.DISCORD_ANNOUNCEMENT_WEBHOOK }}
5750
- name: Capture build artifacts
58-
if: ${{ runner.os == 'Linux' && matrix.java == '17' }} # Only upload artifacts built from LTS java on one OS
59-
uses: actions/upload-artifact@v3
51+
uses: actions/upload-artifact@v4
6052
with:
6153
name: Artifacts
6254
path: build/libs/

0 commit comments

Comments
 (0)