Prevent show/hide children via mouse from scrolling mod list. (#933)

- Don't scroll when show/hide children (Resolves #911)

Author: gniftygnome

src/main/java/com/terraformersmc/modmenu/gui/widget/ModListWidget.java

@@ -158,7 +158,7 @@ private boolean hasVisibleChildMods(Mod parent) {
 		return !children.stream().allMatch(child -> child.isHidden() || hideLibraries && child.getBadges().contains(Mod.Badge.LIBRARY));
 	}
 
-	private void filter(String searchTerm, boolean refresh, boolean search) {
+	public void filter(String searchTerm, boolean refresh, boolean reposition) {
 		this.clearEntries();
 		addedMods.clear();
 		Collection<Mod> mods = ModMenu.MODS.values().stream().filter(mod -> {
@@ -208,6 +208,11 @@ private void filter(String searchTerm, boolean refresh, boolean search) {
 			}
 		}
 
+        if (!reposition) {
+            // This generally leaves the same mod selected, but no mod highlighted, and the scrolling is unmodified.
+            return;
+        }
+
 		if (parent.getSelectedEntry() != null && !children().isEmpty() || this.getSelectedOrNull() != null && getSelectedOrNull().getMod() != parent.getSelectedEntry().getMod()) {
 			for (ModListEntry entry : children()) {
 				if (entry.getMod().equals(parent.getSelectedEntry().getMod())) {

src/main/java/com/terraformersmc/modmenu/gui/widget/entries/ParentEntry.java

@@ -146,7 +146,7 @@ private void toggleChildren() {
 			list.getParent().showModChildren.add(id);
 		}
 
-		list.filter(list.getParent().getSearchInput(), false);
+		list.filter(list.getParent().getSearchInput(), false, false);
 	}
 
 	@Override