Incompatibility: Tensura Reincarnated

[lanathetechwitch]

Checklist

• This is not a support or help request.
• This issue exists on the latest release for my Minecraft version.
• This issue has not already been reported.
• I have determined the minimal reproduction requirements.

Mod Loader

NeoForge 21.1.231

Minecraft Version

1.21.1

Mod Version

2.2.1+1.21.1

Log File

https://mclo.gs/5KmXt2g

Crash Report (optional)

https://mclo.gs/9ezAbS0

Issue Description

Hey lovely ClientSort devs,

There is a hard UI conflict in the main player inventory between Tensura: Reincarnated and Client Sort. Tensura adds (or causes to be displayed) a tab on top of the vanilla player inventory. I believe the mod adds several other tabs later as players unlock more stuff.

When loaded without Client Sort clicking the tab does nothing, as we are already in the player inventory.
When loaded with Client Sort clicking the tab crashes the render thread (logs and crash reports attached),
with a ConcurrentModificationException on what seems to be some UI related array.

I am currently unsure if this is Tensura injecting their UI incorrectly, or Client Sort not interacting with some mod UIs correctly. I am reporting it here in case this is a general compatibility problem or an oversight on Client Sort side that could potentially affect more mods. From my understanding, Tensura as a mod is effectively an overhaul, touching on a myriad of systems and functions, so I would not be surprised if this is entirely on Tensura's side, and have opened a ticket on their side as well. I will update this ticket if/when they answer.

Using:
Tensura: Reincarnated 2.0.1.0

Tensura dependencies (via Modrinth):
Architectury 13.0.8
Cloth Config v15 API 15.0.140
GeckoLib 4 4.8.4
Manas Core 4.0.0.2
SmartBrainLib 1.16.11
TerraBlender 4.1.0.8

Steps to Reproduce

1. Create new world
2. Close Tensura race dialog by selecting a race
3. Open vanilla inventory
4. Click on the "Inventory" tab displaying a grass block above the player model (see image)
5. Crash

Expected Behavior (optional)

No response

[NotRyken]

Thanks for the detailed report. On ClientSort's side this is caused by adding the sort button after Screen#init(), but I don't know why that'd be an issue unless Tensura is doing something off-thread at the time, or triggering init from within the mouseClicked handler loop, neither of which make much sense here.

I'm going to say the onus is on them at the moment, partly because it's a closed-source mod. Will close this as wontfix in a few days unless they come back with a good reason why CS's behavior should be altered.

ClientSort/common/src/main/java/dev/terminalmc/clientsort/client/gui/TriggerButtonManager.java

Line 337 in 3f2035f

((ScreenAccessor) screen).clientsort$addRenderableWidget(button);