Skip to content

Commit ee56abb

Browse files
committed
ST6RI-828 Removed old getRelevantFeatures mechanism for behaviors/steps.
1 parent 935c8f6 commit ee56abb

10 files changed

Lines changed: 208 additions & 111 deletions

File tree

org.omg.sysml/src/org/omg/sysml/adapter/ActionDefinitionAdapter.java

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*******************************************************************************
22
* SysML 2 Pilot Implementation
3-
* Copyright (c) 2021 Model Driven Solutions, Inc.
3+
* Copyright (c) 2021, 2025 Model Driven Solutions, Inc.
44
*
55
* This program is free software: you can redistribute it and/or modify
66
* it under the terms of the GNU Lesser General Public License as published by
@@ -21,11 +21,7 @@
2121

2222
package org.omg.sysml.adapter;
2323

24-
import java.util.Collections;
25-
import java.util.List;
26-
2724
import org.omg.sysml.lang.sysml.ActionDefinition;
28-
import org.omg.sysml.lang.sysml.Feature;
2925

3026
public class ActionDefinitionAdapter extends OccurrenceDefinitionAdapter {
3127

@@ -38,9 +34,4 @@ public ActionDefinition getTarget() {
3834
return (ActionDefinition)super.getTarget();
3935
}
4036

41-
@Override
42-
public List<Feature> getRelevantFeatures() {
43-
return Collections.emptyList();
44-
}
45-
4637
}

org.omg.sysml/src/org/omg/sysml/adapter/ActionUsageAdapter.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*******************************************************************************
22
* SysML 2 Pilot Implementation
3-
* Copyright (c) 2021-2024 Model Driven Solutions, Inc.
3+
* Copyright (c) 2021-2025 Model Driven Solutions, Inc.
44
*
55
* This program is free software: you can redistribute it and/or modify
66
* it under the terms of the GNU Lesser General Public License as published by
@@ -34,7 +34,6 @@
3434
import org.omg.sysml.lang.sysml.TransitionFeatureMembership;
3535
import org.omg.sysml.lang.sysml.Type;
3636
import org.omg.sysml.util.ImplicitGeneralizationMap;
37-
import org.omg.sysml.util.TypeUtil;
3837

3938
public class ActionUsageAdapter extends OccurrenceUsageAdapter {
4039

@@ -102,11 +101,6 @@ public boolean isComputeRedefinitions() {
102101
super.isComputeRedefinitions();
103102
}
104103

105-
@Override
106-
public List<? extends Feature> getRelevantFeatures() {
107-
return TypeUtil.getItemFeaturesOf(getTarget());
108-
}
109-
110104
@Override
111105
protected List<? extends Feature> getRelevantFeatures(Type type, Element skip) {
112106
ActionUsage target = getTarget();

org.omg.sysml/src/org/omg/sysml/adapter/BehaviorAdapter.java

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*******************************************************************************
22
* SysML 2 Pilot Implementation
3-
* Copyright (c) 2021 Model Driven Solutions, Inc.
3+
* Copyright (c) 2021, 2025 Model Driven Solutions, Inc.
44
*
55
* This program is free software: you can redistribute it and/or modify
66
* it under the terms of the GNU Lesser General Public License as published by
@@ -21,11 +21,7 @@
2121

2222
package org.omg.sysml.adapter;
2323

24-
import java.util.List;
25-
2624
import org.omg.sysml.lang.sysml.Behavior;
27-
import org.omg.sysml.lang.sysml.Feature;
28-
import org.omg.sysml.util.TypeUtil;
2925

3026
public class BehaviorAdapter extends ClassAdapter {
3127

@@ -38,12 +34,4 @@ public Behavior getTarget() {
3834
return (Behavior)super.getTarget();
3935
}
4036

41-
/**
42-
* Return the non-parameter abstract features of the Behavior.
43-
*/
44-
@Override
45-
public List<Feature> getRelevantFeatures() {
46-
return TypeUtil.getNonParameterAbstractFeaturesFor(getTarget());
47-
}
48-
4937
}

org.omg.sysml/src/org/omg/sysml/adapter/FeatureAdapter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*******************************************************************************
22
* SysML 2 Pilot Implementation
3-
* Copyright (c) 2021-2024 Model Driven Solutions, Inc.
3+
* Copyright (c) 2021-2025 Model Driven Solutions, Inc.
44
*
55
* This program is free software: you can redistribute it and/or modify
66
* it under the terms of the GNU Lesser General Public License as published by
@@ -561,7 +561,7 @@ protected List<? extends Feature> getRelevantFeatures(Type type, Element skip) {
561561
return type == null? Collections.emptyList():
562562
target.isEnd()? TypeUtil.getAllEndFeaturesOf(type):
563563
FeatureUtil.isParameter(target)? getParameterRelevantFeatures(type, skip):
564-
TypeUtil.getRelevantFeaturesOf(type);
564+
Collections.emptyList();
565565
}
566566

567567
/**

org.omg.sysml/src/org/omg/sysml/adapter/FlowAdapter.java

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*******************************************************************************
22
* SysML 2 Pilot Implementation
3-
* Copyright (c) 2021, 2022 Model Driven Solutions, Inc.
3+
* Copyright (c) 2021, 2022, 2025 Model Driven Solutions, Inc.
44
*
55
* This program is free software: you can redistribute it and/or modify
66
* it under the terms of the GNU Lesser General Public License as published by
@@ -21,12 +21,8 @@
2121

2222
package org.omg.sysml.adapter;
2323

24-
import java.util.List;
25-
26-
import org.omg.sysml.lang.sysml.Feature;
2724
import org.omg.sysml.lang.sysml.Flow;
2825
import org.omg.sysml.util.ConnectorUtil;
29-
import org.omg.sysml.util.TypeUtil;
3026

3127
public class FlowAdapter extends ConnectorAdapter {
3228

@@ -57,12 +53,7 @@ public void addDefaultGeneralType() {
5753
protected String getDefaultSupertype() {
5854
return getDefaultSupertype("base");
5955
}
60-
61-
@Override
62-
public List<? extends Feature> getRelevantFeatures() {
63-
return TypeUtil.getItemFeaturesOf(getTarget());
64-
}
65-
56+
6657
@Override
6758
public void doTransform() {
6859
ConnectorUtil.transformConnectorEndsOf(getTarget());

org.omg.sysml/src/org/omg/sysml/adapter/FlowUsageAdapter.java

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*******************************************************************************
22
* SysML 2 Pilot Implementation
3-
* Copyright (c) 2021-2024 Model Driven Solutions, Inc.
3+
* Copyright (c) 2021-2025 Model Driven Solutions, Inc.
44
*
55
* This program is free software: you can redistribute it and/or modify
66
* it under the terms of the GNU Lesser General Public License as published by
@@ -21,14 +21,10 @@
2121

2222
package org.omg.sysml.adapter;
2323

24-
import java.util.List;
25-
26-
import org.omg.sysml.lang.sysml.Feature;
2724
import org.omg.sysml.lang.sysml.FlowUsage;
2825
import org.omg.sysml.lang.sysml.OccurrenceUsage;
2926
import org.omg.sysml.lang.sysml.PortionKind;
3027
import org.omg.sysml.util.ConnectorUtil;
31-
import org.omg.sysml.util.TypeUtil;
3228
import org.omg.sysml.util.UsageUtil;
3329

3430
public class FlowUsageAdapter extends ConnectorAsUsageAdapter {
@@ -88,12 +84,7 @@ protected String getDefaultSupertype() {
8884
getDefaultSupertype("message"):
8985
getDefaultSupertype("base");
9086
}
91-
92-
@Override
93-
public List<? extends Feature> getRelevantFeatures() {
94-
return TypeUtil.getItemFeaturesOf(getTarget());
95-
}
96-
87+
9788
@Override
9889
public void doTransform() {
9990
ConnectorUtil.transformConnectorEndsOf(getTarget());

org.omg.sysml/src/org/omg/sysml/adapter/StepAdapter.java

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*******************************************************************************
22
* SysML 2 Pilot Implementation
3-
* Copyright (c) 2021, 2022 Model Driven Solutions, Inc.
3+
* Copyright (c) 2021, 2022, 2025 Model Driven Solutions, Inc.
44
*
55
* This program is free software: you can redistribute it and/or modify
66
* it under the terms of the GNU Lesser General Public License as published by
@@ -21,12 +21,8 @@
2121

2222
package org.omg.sysml.adapter;
2323

24-
import java.util.List;
25-
26-
import org.omg.sysml.lang.sysml.Feature;
2724
import org.omg.sysml.lang.sysml.PayloadFeature;
2825
import org.omg.sysml.lang.sysml.Step;
29-
import org.omg.sysml.util.TypeUtil;
3026

3127
public class StepAdapter extends FeatureAdapter {
3228

@@ -57,9 +53,4 @@ public boolean isIncomingTransfer() {
5753
return getTarget().getOwnedFeature().stream().anyMatch(PayloadFeature.class::isInstance);
5854
}
5955

60-
@Override
61-
public List<? extends Feature> getRelevantFeatures() {
62-
return TypeUtil.getItemFeaturesOf(getTarget());
63-
}
64-
6556
}

org.omg.sysml/src/org/omg/sysml/adapter/TypeAdapter.java

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -425,18 +425,6 @@ public Type getLibraryType(String... defaultNames) {
425425
return SysMLLibraryUtil.getLibraryType(getTarget(), defaultNames);
426426
}
427427

428-
// Computed Redefinitions
429-
430-
/**
431-
* This method returns those features from the target type that should be automatically overridden in its usages.
432-
* By default, there are none.
433-
*
434-
* @return Relevant features from the target type that should be redefined in usages.
435-
*/
436-
public List<? extends Feature> getRelevantFeatures() {
437-
return Collections.emptyList();
438-
}
439-
440428
// Extension
441429

442430
private boolean isGetBaseTypes = true;

org.omg.sysml/src/org/omg/sysml/util/TypeUtil.java

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@
4343
import org.omg.sysml.lang.sysml.FeatureChaining;
4444
import org.omg.sysml.lang.sysml.FeatureMembership;
4545
import org.omg.sysml.lang.sysml.Specialization;
46-
import org.omg.sysml.lang.sysml.PayloadFeature;
4746
import org.omg.sysml.lang.sysml.Membership;
4847
import org.omg.sysml.lang.sysml.Multiplicity;
4948
import org.omg.sysml.lang.sysml.Namespace;
@@ -489,30 +488,6 @@ public static void insertImplicitBindingConnectors(Type type) {
489488
}
490489
}
491490

492-
// Relevant features
493-
494-
public static List<? extends Feature> getRelevantFeaturesOf(Type type) {
495-
return getTypeAdapter(type).getRelevantFeatures();
496-
}
497-
498-
/**
499-
* Get the non-parameter abstract Features. (For use with Behaviors.)
500-
*/
501-
public static List<Feature> getNonParameterAbstractFeaturesFor(Type type) {
502-
return type.getOwnedFeature().stream().
503-
filter(feature -> !FeatureUtil.isParameter(feature) && feature.isAbstract()).
504-
collect(Collectors.toList());
505-
}
506-
507-
/**
508-
* Get ItemFeatures. (For use with Steps.)
509-
*/
510-
public static List<? extends Feature> getItemFeaturesOf(Type type) {
511-
return type.getOwnedFeature().stream().
512-
filter(PayloadFeature.class::isInstance).
513-
collect(Collectors.toList());
514-
}
515-
516491
// Associations
517492

518493
public static Type getSourceTypeOf(Association association) {

0 commit comments

Comments
 (0)