diff --git a/REVIEW.md b/REVIEW.md index 7db342e..75c0d8a 100644 --- a/REVIEW.md +++ b/REVIEW.md @@ -37,6 +37,34 @@ Code implementation used the verified Cursor Grok 4.6 Extra High conversation th On `3b1efd7`, a local assisted trial accepted an exact saved draft in the browser, reloaded, and reimported the original two research observations. The accepted draft, Ready status, two observations (deduplicated), and review history were retained. No external applications, messages, or Notion writes. Source rows came through the connected Notion tool, not the standalone Notion CLI. Installed Grok Bot JSON was transcribed by hand into a validated file; automatic Bot file transfer was not tested. After this checkout fast-forwarded to `59ec7ac`, a read-only browser reopen still showed the accepted record. +## Round 2 (approved `8ba8400` snapshot based on `2372771`) + +Surgical UI on copy/paste, Relay vs source status labels, redundant accepted actions, and dirty navigation. Independent fictional QA only; the earlier assisted real trial on port 3101 was not repeated or mutated. + +Astra 6 High review then required four corrections, implemented here without publication: + +1. Exact acceptance uses the current job identity/version, no conflict, matching `accepted_draft`, and an unchanged draft and blocker. Queue hint shares that condition. External Ready refresh → conflict → revert to the old base is not labeled accepted. +2. Pasted input is bounded by UTF-8 byte size (1.8 MB), with a cheap character bound first. A valid JSON envelope under the character limit and over the byte limit is rejected. The 20,000-character draft bound is unchanged. +3. Docs distinguish outbound `relay.packet.v1` copy/download from inbound `relay.draft.v1` paste/load. Prior assisted-trial Bot JSON remains a hand transcription. No fresh installed-Bot roundtrip is claimed. +4. Remaining `pnpm audit` after the approved React 19.2.8 / Vite 8.0.16 patch: **19 advisories (8 high, 8 moderate, 3 low)** in esbuild, image-size, sharp, undici, and ws. Baseline was 22 (10 high, 9 moderate, 3 low). Evidence: `work/round2-postpatch-audit.json`. No further dependency updates in this round. + +- `pnpm test`: **55 passed, 0 failed**. Coverage adds the conflict-revert acceptance case and a multibyte paste envelope over 1.8 MB bytes. No source-string tests. +- `pnpm exec tsc --noEmit`, `pnpm lint`, `pnpm build`: passed on Vite 8.0.16. Build kept the framework route-classification notice. +- Direct dependencies moved only to `react`/`react-dom`/`react-server-dom-webpack` 19.2.8 and `vite` 8.0.16. Lockfile also resolved Vite’s `rolldown` 1.0.1 → 1.0.3 and required `@oxc-project/types` 0.133.0. No overrides. +- Migrations 0000, 0001, and 0002 applied to this checkout’s `.wrangler/state`. Dev server: `http://localhost:3102/` (listens on `[::1]:3102`). +- Initial fictional browser pass is retained at ignored `private-data/work/round2-browser-qa-initial.json`. Tightened corrections pass (`private-data/work/round2-corrections-browser-qa.json`): copy serializer matched download (Windows clipboard CRLF vs file LF, normalized equality); induced clipboard rejection showed the fallback and left download available; valid paste staged exact text with no database write; prose/wrong-job/stale/oversized paste left editor and stored state unchanged; unchanged Ready on All opportunities disabled Save/Accept with no extra version or event; word edit dropped the accepted hint; Save revoked Ready; explicit reaccept stored the new text; external Ready v2 plus revert did not label stale text accepted; blocker-only dirty cancel/save; current-filter no-op; same-job reselect; dirty job/filter cancel/confirm; delayed file load across a job switch left the later editor unchanged; held in-flight Maple save did not overwrite the Northstar editor. Source Ready rendered beside Relay Held. +- Not done here: `tests/api.test.mjs`, live Claude, installed Bot transport, production deploy, commit, or push. Port 3101 / live-trial database were not used. + +## PR24 integration with merged main `e037ebf` + +Uncommitted merge on `codex/round2-draft-handoffs`: head under review is `8ba8400` plus exact `e037ebf468fd1203bd2667ada244137d91794c99`. Merge base `2372771`. Content conflicts were only `package.json` and `pnpm-lock.yaml`; both were resolved to the complete `e037ebf` files. Round2 application, helper, and test files were not rewritten. + +Fresh checks on this runtime (Node 24.19.0, pnpm 11.19.0, frozen lockfile, owned `node_modules`): `git diff --check` exit 0; `pnpm lint` exit 0; `pnpm typecheck` exit 0; `pnpm test` via `scripts/ci/run-unit.mjs` **64 passed, 0 failed** (discovered `auth`, `connectors`, `deployment`, `domain`, `editor`, `import`, `obsidian`; `api.test.mjs` excluded by design); `pnpm build` exit 0 on Vite 8.0.16 with the framework route-classification notice; `pnpm audit --audit-level high` exit 0, remaining **2 advisories (1 moderate, 1 low)** in esbuild; `pnpm test:api` PASS; `pnpm test:production` PASS. Local `pnpm test:e2e` did not launch: Playwright 1.63 looks for `chromium_headless_shell-1243` under the Cursor sandbox browser cache; tracked e2e tests were not changed. Canonical remote CI remains required. + +Fictional browser regression (not an installed-Bot trial): ignored `private-data/work/round2-main-integration-browser-qa.json` and `.png`. Copy matched download after Windows CRLF normalization (382 vs 370); induced clipboard failure kept download; paste staged exact text with no writes; invalid/wrong-job/stale/oversized inputs left the editor unchanged; exact acceptance disabled redundant Save/Accept; word and blocker edits remained reviewable; Ready external-conflict reversion was not labeled accepted; same-job/current-filter preserved the editor; dirty cancel/discard worked; delayed file read and a held in-flight save left the later editor intact. + +The historical 55-test / 19-advisory / no-overrides snapshot above describes `8ba8400`, not this integrated runtime. No production, live Claude, fresh installed-Bot roundtrip, or independent adoption is claimed. + ## Coverage limits Original code review (base `6f88ea2`) did not include browser interactions or real-provider accounts; connector responses were mocked. The later local assisted trial above does not validate live Claude, production deployment, independent user adoption, unattended production, or external submissions. Lost observations need source reimport. Acceptance repair is limited to missing/mismatched accepted text. No deployment was performed. Ignored implementation and verification logs remain under `work/`. diff --git a/app/globals.css b/app/globals.css index b0d6125..8542716 100644 --- a/app/globals.css +++ b/app/globals.css @@ -1,4 +1,3 @@ -@import 'tailwindcss'; :root { --ink: #24352f; --muted: #6a756e; diff --git a/components.json b/components.json deleted file mode 100644 index f382eb7..0000000 --- a/components.json +++ /dev/null @@ -1,25 +0,0 @@ -{ - "$schema": "https://ui.shadcn.com/schema.json", - "style": "base-nova", - "rsc": true, - "tsx": true, - "tailwind": { - "config": "", - "css": "app/globals.css", - "baseColor": "neutral", - "cssVariables": true, - "prefix": "" - }, - "iconLibrary": "lucide", - "rtl": false, - "aliases": { - "components": "@/components", - "utils": "@/lib/utils", - "ui": "@/components/ui", - "lib": "@/lib", - "hooks": "@/hooks" - }, - "menuColor": "default", - "menuAccent": "subtle", - "registries": {} -} diff --git a/components/ui/accordion.tsx b/components/ui/accordion.tsx deleted file mode 100644 index 9daf7bf..0000000 --- a/components/ui/accordion.tsx +++ /dev/null @@ -1,78 +0,0 @@ -import { Accordion as AccordionPrimitive } from '@base-ui/react/accordion'; - -import { cn } from '@/lib/utils'; -import { ChevronDownIcon, ChevronUpIcon } from 'lucide-react'; - -function Accordion({ className, ...props }: AccordionPrimitive.Root.Props) { - return ( - - ); -} - -function AccordionItem({ className, ...props }: AccordionPrimitive.Item.Props) { - return ( - - ); -} - -function AccordionTrigger({ - className, - children, - ...props -}: AccordionPrimitive.Trigger.Props) { - return ( - - - {children} - - - - - ); -} - -function AccordionContent({ - className, - children, - ...props -}: AccordionPrimitive.Panel.Props) { - return ( - -
- {children} -
-
- ); -} - -export { Accordion, AccordionItem, AccordionTrigger, AccordionContent }; diff --git a/components/ui/alert-dialog.tsx b/components/ui/alert-dialog.tsx deleted file mode 100644 index 46d9eb7..0000000 --- a/components/ui/alert-dialog.tsx +++ /dev/null @@ -1,187 +0,0 @@ -'use client'; - -import * as React from 'react'; -import { AlertDialog as AlertDialogPrimitive } from '@base-ui/react/alert-dialog'; - -import { cn } from '@/lib/utils'; -import { Button } from '@/components/ui/button'; - -function AlertDialog({ ...props }: AlertDialogPrimitive.Root.Props) { - return ; -} - -function AlertDialogTrigger({ ...props }: AlertDialogPrimitive.Trigger.Props) { - return ( - - ); -} - -function AlertDialogPortal({ ...props }: AlertDialogPrimitive.Portal.Props) { - return ( - - ); -} - -function AlertDialogOverlay({ - className, - ...props -}: AlertDialogPrimitive.Backdrop.Props) { - return ( - - ); -} - -function AlertDialogContent({ - className, - size = 'default', - ...props -}: AlertDialogPrimitive.Popup.Props & { - size?: 'default' | 'sm'; -}) { - return ( - - - - - ); -} - -function AlertDialogHeader({ - className, - ...props -}: React.ComponentProps<'div'>) { - return ( -
- ); -} - -function AlertDialogFooter({ - className, - ...props -}: React.ComponentProps<'div'>) { - return ( -
- ); -} - -function AlertDialogMedia({ - className, - ...props -}: React.ComponentProps<'div'>) { - return ( -
- ); -} - -function AlertDialogTitle({ - className, - ...props -}: React.ComponentProps) { - return ( - - ); -} - -function AlertDialogDescription({ - className, - ...props -}: React.ComponentProps) { - return ( - - ); -} - -function AlertDialogAction({ - className, - ...props -}: React.ComponentProps) { - return ( - - ); -} - -function CarouselNext({ - className, - variant = 'outline', - size = 'icon-sm', - ...props -}: React.ComponentProps) { - const { orientation, scrollNext, canScrollNext } = useCarousel(); - - return ( - - ); -} - -export { - type CarouselApi, - Carousel, - CarouselContent, - CarouselItem, - CarouselPrevious, - CarouselNext, - useCarousel, -}; diff --git a/components/ui/chart.tsx b/components/ui/chart.tsx deleted file mode 100644 index 0680cf0..0000000 --- a/components/ui/chart.tsx +++ /dev/null @@ -1,373 +0,0 @@ -'use client'; - -import * as React from 'react'; -import * as RechartsPrimitive from 'recharts'; -import type { TooltipValueType } from 'recharts'; - -import { cn } from '@/lib/utils'; - -// Format: { THEME_NAME: CSS_SELECTOR } -const THEMES = { light: '', dark: '.dark' } as const; - -const INITIAL_DIMENSION = { width: 320, height: 200 } as const; -type TooltipNameType = number | string; - -export type ChartConfig = Record< - string, - { - label?: React.ReactNode; - icon?: React.ComponentType; - } & ( - | { color?: string; theme?: never } - | { color?: never; theme: Record } - ) ->; - -type ChartContextProps = { - config: ChartConfig; -}; - -const ChartContext = React.createContext(null); - -function useChart() { - const context = React.useContext(ChartContext); - - if (!context) { - throw new Error('useChart must be used within a '); - } - - return context; -} - -function ChartContainer({ - id, - className, - children, - config, - initialDimension = INITIAL_DIMENSION, - ...props -}: React.ComponentProps<'div'> & { - config: ChartConfig; - children: React.ComponentProps< - typeof RechartsPrimitive.ResponsiveContainer - >['children']; - initialDimension?: { - width: number; - height: number; - }; -}) { - const uniqueId = React.useId(); - const chartId = `chart-${id ?? uniqueId.replace(/:/g, '')}`; - - return ( - -
- - - {children} - -
-
- ); -} - -const ChartStyle = ({ id, config }: { id: string; config: ChartConfig }) => { - const colorConfig = Object.entries(config).filter( - ([, config]) => config.theme ?? config.color, - ); - - if (!colorConfig.length) { - return null; - } - - return ( -