Make some structs to classes, Make all JsonConverters internal

Author: Suiram1701

API.Test/TimeTableTests.cs

@@ -32,7 +32,7 @@ public void GetTimeGrid()
 
         Task<Timegrid> timegrid = Client.GetTimegridAsync();
         timegrid.Wait();
-        if (timegrid.Result.SchoolDays > 0)
+        if (timegrid.Result.SchoolDayCount > 0)
             Assert.Pass();
         else
             Assert.Fail();

WebUntisAPI.Client/Converter/ClassJsonConverter.cs

@@ -14,7 +14,7 @@ namespace WebUntisAPI.Client.Converter
     /// <summary>
     /// Convert the teachers in webuntis get classes response to int array
     /// </summary>
-    public sealed class ClassJsonConverter : JsonConverter<Class>
+    internal class ClassJsonConverter : JsonConverter<Class>
     {
         /// <inheritdoc/>
         public override Class ReadJson(JsonReader reader, Type objectType, Class existingValue, bool hasExistingValue, JsonSerializer serializer)

WebUntisAPI.Client/Converter/ColorJsonConverter.cs

@@ -14,7 +14,7 @@ namespace WebUntisAPI.Client.Converter
     /// <summary>
     /// A json converter to convert a <see cref="Color"/> to the Hex color format (RRGGBB)
     /// </summary>
-    public sealed class ColorJsonConverter : JsonConverter<Color>
+    internal class ColorJsonConverter : JsonConverter<Color>
     {
         /// <inheritdoc/>
         public override Color ReadJson(JsonReader reader, Type objectType, Color existingValue, bool hasExistingValue, JsonSerializer serializer)

WebUntisAPI.Client/Converter/TimegridJsonConverter.cs

@@ -10,7 +10,7 @@
 
 namespace WebUntisAPI.Client.Converter
 {
-    internal sealed class TimegridJsonConverter : JsonConverter<Timegrid>
+    internal class TimegridJsonConverter : JsonConverter<Timegrid>
     {
         /// <inheritdoc/>
         public override Timegrid ReadJson(JsonReader reader, Type objectType, Timegrid existingValue, bool hasExistingValue, JsonSerializer serializer)
@@ -24,7 +24,7 @@ public override Timegrid ReadJson(JsonReader reader, Type objectType, Timegrid e
                 foreach (JObject hour in dayTimegrid["timeUnits"].Cast<JObject>())
                     hours.Add(serializer.Deserialize<SchoolHour>(hour.CreateReader()));
 
-                timegrid[(Day)dayTimegrid["day"].Value<int>()] = hours.ToArray();
+                timegrid.SchoolDays.Add((Day)dayTimegrid["day"].Value<int>(), hours.ToArray());
             }
             return timegrid;
         }

WebUntisAPI.Client/Models/Holidays.cs

@@ -13,7 +13,7 @@ namespace WebUntisAPI.Client.Models
     /// A holiday
     /// </summary>
     [DebuggerDisplay("Name: {LongName, nq}")]
-    public struct Holidays
+    public class Holidays
     {
         /// <summary>
         /// The id of the holiday

WebUntisAPI.Client/Models/Timegrid.cs

@@ -17,34 +17,19 @@ namespace WebUntisAPI.Client.Models
     [JsonConverter(typeof(TimegridJsonConverter))]
     public class Timegrid : IEnumerable<(Day, SchoolHour[])>
     {
-        private readonly Dictionary<Day, SchoolHour[]> _schoolDays = new Dictionary<Day, SchoolHour[]>();
-
         /// <summary>
-        /// The count of school hours (mostly 5)
+        /// All the school days with their school hours
         /// </summary>
-        public int SchoolDays => _schoolDays.Count;
+        public Dictionary<Day, SchoolHour[]> SchoolDays { get; set; } = new Dictionary<Day, SchoolHour[]>();
 
         /// <summary>
-        /// Get the school hours by the day
+        /// The count of school days (mostly 5)
         /// </summary>
-        /// <param name="day">The day</param>
-        /// <returns>The school hours</returns>
-        /// <exception cref="KeyNotFoundException">Thrown when the given day not found (mostly <see cref="Day.Saturday"/> and <see cref="Day.Sunday"/>)</exception>
-        public SchoolHour[] this[Day day]
-        {
-            get => _schoolDays[day];
-            set
-            {
-                if (_schoolDays.ContainsKey(day))
-                    _schoolDays[day] = value;
-                else
-                    _schoolDays.Add(day, value);
-            }
-        }
+        public int SchoolDayCount => SchoolDays.Count;
 
         #region IEnumerable<SchoolHour[]>
         /// <inheritdoc/>
-        public IEnumerator<(Day, SchoolHour[])> GetEnumerator() => _schoolDays.Keys.Zip(_schoolDays.Values, (day, schoolHours) => (day, schoolHours)).GetEnumerator();
+        public IEnumerator<(Day, SchoolHour[])> GetEnumerator() => SchoolDays.Keys.Zip(SchoolDays.Values, (day, schoolHours) => (day, schoolHours)).GetEnumerator();
 
         IEnumerator IEnumerable.GetEnumerator() => GetEnumerator();
         #endregion