Merge branch 'hotfix/v1.2.1'

Author: Suiram1701

API.Test/MessagesTests.cs

@@ -102,6 +102,20 @@ public void GetStaffFilters()
             Assert.Fail();
     }
 
+    [Test]
+    public void GetSearchedStaffPeople()
+    {
+        Client.LoginAsync(s_Server, s_LoginName, s_UserName, s_Password).Wait();
+
+        Task<MessagePerson[]> filters = Client.GetStaffFilterSearchResultAsync("", new());
+        filters.Wait();
+
+        if (filters.Result.Length > 0)
+            Assert.Pass();
+        else
+            Assert.Fail();
+    }
+
     [Test]
     public void GetDrafts()
     {

WebUntisAPI.Client/WebUntisAPI.Client.csproj

@@ -16,9 +16,9 @@
     <Copyright>Copyright © Suiram1 2023</Copyright>
     <Description>A library in .NET to interact with the WebUntis API.</Description>
     <Company>Suiram1</Company>
-    <AssemblyVersion>1.2.0</AssemblyVersion>
-    <FileVersion>1.2.0</FileVersion>
-    <Version>1.2.0</Version>
+    <AssemblyVersion>1.2.1</AssemblyVersion>
+    <FileVersion>1.2.1</FileVersion>
+    <Version>1.2.1</Version>
   </PropertyGroup>
 
   <ItemGroup>

WebUntisAPI.Client/WebUntisClient.Messages.cs

@@ -148,7 +148,7 @@ public async Task<MessagePerson[]> GetStaffFilterSearchResultAsync(string search
             {
                 Method = HttpMethod.Post,
                 RequestUri = new Uri(ServerUrl + $"/WebUntis/api/rest/view/v2/messages/recipients/STAFF/filter"),
-                Content = new StringContent(sw.ToString())
+                Content = new StringContent(sw.ToString(), Encoding.UTF8, "application/json")
             };
             request.Headers.Add("JSESSIONID", _sessionId);
             request.Headers.Add("schoolname", _schoolName);
@@ -169,7 +169,7 @@ public async Task<MessagePerson[]> GetStaffFilterSearchResultAsync(string search
             string responseString = await response.Content.ReadAsStringAsync();
 
             JObject obj = JObject.Parse(responseString);
-            return obj["users"].Value<List<MessagePerson>>().ToArray();
+            return obj["users"].ToObject<List<MessagePerson>>().ToArray();
         }
 
         /// <summary>

WebUntisAPI.Client/WebUntisclient.Profile.cs

@@ -131,7 +131,7 @@ public async Task<Image> GetMessagePersonProfileImageAsync(MessagePerson person,
 
 #if NET47 || NET481
             Image image = Image.FromStream(await response.Content.ReadAsStreamAsync());
-            
+
             if (image.Height == image.Width)
                 return image;
 
@@ -230,14 +230,14 @@ public async Task<GeneralAccount> GetGenerallyAccountInformationAsync(Cancellati
         /// <exception cref="HttpRequestException">Thrown when an error happened while the http request</exception>
         public async Task<(ContactDetails contact, bool canRead, bool canWrite)> GetContactDetailsAsync(CancellationToken ct = default)
         {
-            string responseString = await MakeAPIGetRequestAsync($"/WebUntis/api/profile/contactdetails?personId={User.Id}&isRequestForStudent={UserType is Client.UserType.Student}", ct);
+            string responseString = await MakeAPIGetRequestAsync($"/WebUntis/api/profile/contactdetails?personId={User.Id}&isRequestForStudent=false", ct);
             JObject data = JObject.Parse(responseString)["data"].Value<JObject>();
 
             if (!data["read"].Value<bool>())     // Return null when you do not have a read permission
                 return (null, false, data["write"].Value<bool>());
 
             ContactDetails contact = data["address"].ToObject<ContactDetails>();
-            return (contact, true, data["write"].Value<bool>());
+            return (contact, data["read"].Value<bool>(), data["write"].Value<bool>());
         }
 
         /// <summary>
@@ -289,7 +289,7 @@ public async Task<GeneralAccount> GetGenerallyAccountInformationAsync(Cancellati
                 throw new HttpRequestException($"There was an error while the http request (Code: {response.StatusCode}).");
 
 #if NET47 || NET481
-                Image image = Image.FromStream(await response.Content.ReadAsStreamAsync());
+            Image image = Image.FromStream(await response.Content.ReadAsStreamAsync());
 #elif NET6_0_OR_GREATER
             Image image = await Image.LoadAsync(await response.Content.ReadAsStreamAsync(ct), ct);
 #endif