Surface real ffmpeg errors; disable unavailable hardware encoders#20
Closed
StuartCameronCode wants to merge 1 commit into
Closed
Surface real ffmpeg errors; disable unavailable hardware encoders#20StuartCameronCode wants to merge 1 commit into
StuartCameronCode wants to merge 1 commit into
Conversation
When an encoder ffmpeg fails (e.g. a hardware encoder not present in the
bundled ffmpeg), vspipe dies with SIGPIPE writing to the closed pipe, and
the worker reported that symptom ("vspipe exited with signal 13") instead
of the cause. Now:
- pipeline_executor checks ffmpeg's status first and includes the tail of
its stderr in the error, so the user sees e.g. "Unknown encoder
'h264_qsv'". A vspipe SIGPIPE is no longer reported when it's just the
downstream pipe closing (ffmpeg's result is authoritative).
- The settings UI now disables (not just warns on) hardware encoders that
ffmpeg didn't report as compiled into this build, with a clear "Not
available in this build" reason — preventing a guaranteed-to-fail encode.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Owner
Author
|
Closing the PR per request; the changes are kept on the fix-encoder-errors-and-ui branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses a user report: forcing QuickSync (not present in the bundled ffmpeg) produced the cryptic
vspipe exited with signal 13 (SIGPIPE).#1 — Surface the real ffmpeg error
vspipe | ffmpeg: when ffmpeg fails, vspipe dies with SIGPIPE on the closed pipe, and we reported that (checked before ffmpeg). Nowpipeline_executor:ffmpeg exited with exit code 1: ... Unknown encoder 'h264_qsv';#2 — Disable unavailable hardware encoders
HardwareEncoderDetectoralready knows which encoders are compiled into the bundled ffmpeg. The settings UI now disables undetected hardware encoders (greyed, non-selectable, "Not available in this build") instead of letting users force a guaranteed failure.Not addressed here (separate, by design): actually shipping a hw-enabled Linux ffmpeg + a runtime functional probe (the discussed #3).
🤖 Generated with Claude Code