From c28023da85282f920533b6c115f2471f1dea7479 Mon Sep 17 00:00:00 2001
From: "vivi-the-going-merry[bot]"
 <308115520+vivi-the-going-merry[bot]@users.noreply.github.com>
Date: Thu, 17 Sep 2026 14:57:06 -0600
Subject: [PATCH 1/2] Fix invalid label for= references on the styles page (IBM
 label_ref_valid)

The "Vertical Spacing", "Input Field Padding", "Base Font Size", and "Corner
Radius" headings pointed at the slider component's hidden storage input
(type="hidden" is not a labelable element), and "Field Shape"/"Style Class"
pointed at ids that were never rendered at all. None of these headings ever
had a single real control to label - the sliders' actual visible inputs
already carry their own aria-label, and Style Class has no control at all.
Drop the dangling for attribute rather than invent a target.

Closes Strategy11/formidable-pro#6690
---
 classes/views/styles/_field-sizes.php    |  9 +++------
 classes/views/styles/_general.php        |  3 +--
 classes/views/styles/_quick-settings.php | 18 ++++++------------
 3 files changed, 10 insertions(+), 20 deletions(-)

diff --git a/classes/views/styles/_field-sizes.php b/classes/views/styles/_field-sizes.php
index 65890b3223..6d5fcabfa1 100644
--- a/classes/views/styles/_field-sizes.php
+++ b/classes/views/styles/_field-sizes.php
@@ -74,8 +74,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Width', 'formidable' ); ?></la
 	?>
 </div>
 <div class="frm5 frm_form_field">
-	<label 
-		for="frm_field_pad"
+	<label
 		class="frm-style-item-heading"><?php esc_html_e( 'Padding', 'formidable' ); ?></label>
 </div>
 <div class="frm7 frm_form_field">
@@ -92,8 +91,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Padding', 'formidable' ); ?></
 	?>
 </div>
 <div class="frm5 frm_form_field">
-	<label 
-		for="frm_field_margin"
+	<label
 		class="frm-style-item-heading"><?php esc_html_e( 'Margin', 'formidable' ); ?></label>
 </div>
 <div class="frm7 frm_form_field">
@@ -110,8 +108,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Margin', 'formidable' ); ?></l
 	?>
 </div>
 <div class="frm5 frm_form_field">
-	<label 
-		for="frm_border_radius"
+	<label
 		class="frm-style-item-heading"><?php esc_html_e( 'Corner Radius', 'formidable' ); ?></label>
 </div>
 <div class="frm7 frm_form_field">
diff --git a/classes/views/styles/_general.php b/classes/views/styles/_general.php
index 01e1ee83a0..982f140a29 100644
--- a/classes/views/styles/_general.php
+++ b/classes/views/styles/_general.php
@@ -178,8 +178,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Center Form', 'formidable' );
 		?>
 </div>
 <div class="frm5 frm_form_field">
-	<label 
-		for="frm_style_class"
+	<label
 		class="frm-style-item-heading"><?php esc_html_e( 'Style Class', 'formidable' ); ?></label>
 </div>
 <div class="frm7 frm_form_field frm-style-component">
diff --git a/classes/views/styles/_quick-settings.php b/classes/views/styles/_quick-settings.php
index 82b4716d1c..015d61e654 100644
--- a/classes/views/styles/_quick-settings.php
+++ b/classes/views/styles/_quick-settings.php
@@ -118,8 +118,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Button Text', 'formidable' );
 <hr class="frm12"/>
 
 <div class="frm5 frm_form_field">
-	<label 
-		for="frm_field_margin"
+	<label
 		class="frm-style-item-heading"><?php esc_html_e( 'Vertical Spacing', 'formidable' ); ?></label>
 </div>
 <div class="frm7 frm_form_field">
@@ -139,8 +138,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Vertical Spacing', 'formidable
 </div>
 
 <div class="frm5 frm_form_field">
-	<label 
-		for="frm_field_pad"
+	<label
 		class="frm-style-item-heading"><?php esc_html_e( 'Input Field Padding', 'formidable' ); ?></label>
 </div>
 <div class="frm7 frm_form_field">
@@ -160,8 +158,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Input Field Padding', 'formida
 </div>
 <hr class="frm12"/>
 <div class="frm5 frm_form_field">
-	<label 
-		for="frm_base_font_size"
+	<label
 		class="frm-style-item-heading"><?php esc_html_e( 'Base Font Size', 'formidable' ); ?></label>
 </div>
 <div class="frm7 frm_form_field">
@@ -189,8 +186,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Base Font Size', 'formidable'
 <hr class="frm12"/>
 
 <div class="frm5 frm_form_field">
-	<label 
-		for="frm_field_shape"
+	<label
 		class="frm-style-item-heading"><?php esc_html_e( 'Field Shape', 'formidable' ); ?></label>
 </div>
 <div class="frm7 frm_form_field frm-sm-z-index">
@@ -206,8 +202,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Field Shape', 'formidable' );
 </div>
 
 <div class="frm5 frm_form_field frm_hidden" data-frm-element="field-shape-corner-radius">
-	<label 
-		for="frm_border_radius"
+	<label
 		class="frm-style-item-heading"><?php esc_html_e( 'Corner Radius', 'formidable' ); ?></label>
 </div>
 <div class="frm7 frm_form_field frm_hidden frm-md-z-index" data-frm-element="field-shape-corner-radius">
@@ -274,8 +269,7 @@ class="frm-style-item-heading">
 	?>
 </div>
 <div class="frm3 frm_form_field">
-	<label 
-		for="frm_style_class"
+	<label
 		class="frm-style-item-heading"><?php esc_html_e( 'Style Class', 'formidable' ); ?></label>
 </div>
 <div class="frm9 frm_form_field frm-style-component" id="frm_style_class_custom_css" data-css-scope="<?php echo esc_attr( 'frm_style_' . $style->post_name ); ?>">

From 2c6ba348661adafa671cb8677d911dd8075e3c62 Mon Sep 17 00:00:00 2001
From: "vivi-the-going-merry[bot]"
 <308115520+vivi-the-going-merry[bot]@users.noreply.github.com>
Date: Thu, 17 Sep 2026 15:01:12 -0600
Subject: [PATCH 2/2] Drop the now-dead frm_field_shape id key

Nothing renders it (FrmFieldShapeStyleComponent's template hardcodes its
own radio ids) and its only consumer was the label removed in the previous
commit.
---
 classes/views/styles/_quick-settings.php | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/classes/views/styles/_quick-settings.php b/classes/views/styles/_quick-settings.php
index 015d61e654..d8972bba4c 100644
--- a/classes/views/styles/_quick-settings.php
+++ b/classes/views/styles/_quick-settings.php
@@ -194,9 +194,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Field Shape', 'formidable' );
 	new FrmFieldShapeStyleComponent(
 		$frm_style->get_field_name( 'field_shape_type' ),
 		$style->post_content['field_shape_type'],
-		array(
-			'id' => 'frm_field_shape',
-		)
+		array()
 	);
 	?>
 </div>