Made changes suggested in review

Author: sriramyab

README.md

@@ -79,7 +79,7 @@ In the directory organization above:
 
       * [2021 Google Android Derived Dataset](https://www.kaggle.com/c/google-smartphone-decimeter-challenge)
       * [2022 Google Android Derived Dataset](https://www.kaggle.com/competitions/smartphone-decimeter-2022)
-      * [Precise Ephemeris Dataset](https://cddis.nasa.gov/Data_and_Derived_Products/GNSS/gnss_mgex.html)
+      * [Precise Ephemeris Data](https://cddis.nasa.gov/Data_and_Derived_Products/GNSS/gnss_mgex.html)
 
   * The `utils` directory contains utilities used to handle
     GNSS measurements, time conversions, visualizations, satellite

docs/source/index.rst

@@ -88,7 +88,7 @@ In the directory organization above:
 
       * `2021 Google Android Derived Dataset <https://www.kaggle.com/c/google-smartphone-decimeter-challenge>`__
       * `2022 Google Android Derived Dataset <https://www.kaggle.com/competitions/smartphone-decimeter-2022>`__
-      * `Precise Ephemeris Dataset <https://cddis.nasa.gov/Data_and_Derived_Products/GNSS/gnss_mgex.html>`__
+      * `Precise Ephemeris Data <https://cddis.nasa.gov/Data_and_Derived_Products/GNSS/gnss_mgex.html>`__
 
   * The :code:`utils` directory contains utilities used to handle
     GNSS measurements, time conversions, visualizations, satellite

gnss_lib_py/algorithms/multi_gnss.py

@@ -42,7 +42,6 @@ def __init__(self, input_path, remove_timing_outliers=True):
 
         """
         pd_df = pd.read_csv(input_path)
-
         # Correction 1: Mapping _derived timestamps to previous timestamp
         # for correspondance with ground truth and Raw data
         derived_timestamps = pd_df['millisSinceGpsEpoch'].unique()
@@ -83,8 +82,7 @@ def postprocess(self):
                      - self['intersignal_bias_m'] \
                      - self['tropo_delay_m'] \
                      - self['iono_delay_m']
-        self['corr_pr_m'] = pr_corrected
-        
+        self['corr_pr_m'] = pr_corrected        
         # rename gnss_id column to constellation type
         constellation_map = {0.:"unknown",
                              1.:"gps",

gnss_lib_py/parsers/android.py

@@ -123,91 +123,11 @@
    "source": [
     "figs = plot_metric_by_constellation(galileo_data, \"gps_millis\", \"residuals_m\")"
    ]
-  },
-  {
-   "cell_type": "markdown",
-   "id": "44e300c3",
-   "metadata": {},
-   "source": [
-    "# Multi-GNSS"
-   ]
-  },
-  {
-   "cell_type": "markdown",
-   "id": "f92ade32",
-   "metadata": {},
-   "source": [
-    "Solve for precise ephemerides and update derived_data class using array of sp3 and clk classes."
-   ]
-  },
-  {
-   "cell_type": "code",
-   "execution_count": null,
-   "id": "c6708193",
-   "metadata": {},
-   "outputs": [],
-   "source": [
-    "from gnss_lib_py.parsers.precise_ephemerides import parse_sp3, parse_clockfile\n",
-    "from gnss_lib_py.algorithms.multi_gnss import compute_sv_gnss_from_precise_eph"
-   ]
-  },
-  {
-   "cell_type": "code",
-   "execution_count": null,
-   "id": "3647db8d",
-   "metadata": {},
-   "outputs": [],
-   "source": [
-    "# load Android Google Challenge data\n",
-    "!wget https://raw.githubusercontent.com/Stanford-NavLab/gnss_lib_py/ramya/multiGNSS_sp3/data/unit_test/android_2021/Pixel4_derived_clkdiscnt.csv --quiet -O \"Pixel4_derived_clkdiscnt.csv\"\n",
-    "derived_data = AndroidDerived2021(\"Pixel4_derived_clkdiscnt.csv\", remove_timing_outliers=False)\n",
-    "derived_data_gps = derived_data.where(\"gnss_id\", \"gps\")"
-   ]
-  },
-  {
-   "cell_type": "code",
-   "execution_count": null,
-   "id": "b4601453",
-   "metadata": {},
-   "outputs": [],
-   "source": [
-    "# download .sp3 data file\n",
-    "!wget https://raw.githubusercontent.com/Stanford-NavLab/gnss_lib_py/ramya/multiGNSS_sp3/data/unit_test/precise_ephemeris/grg21553_short.sp3 --quiet -O \"grg21553_short.sp3\"\n",
-    "\n",
-    "# Parse precise ephemerides, i.e., satellite position, from .sp3 data\n",
-    "sp3data_gps = parse_sp3(\"grg21553_short.sp3\", constellation = 'gps')"
-   ]
-  },
-  {
-   "cell_type": "code",
-   "execution_count": null,
-   "id": "9db551d2",
-   "metadata": {},
-   "outputs": [],
-   "source": [
-    "# download .clk data file\n",
-    "!wget https://raw.githubusercontent.com/Stanford-NavLab/gnss_lib_py/ramya/multiGNSS_sp3/data/unit_test/precise_ephemeris/grg21553_short.clk --quiet -O \"grg21553_short.clk\"\n",
-    "\n",
-    "# Parse precise ephemerides, i.e., satellite clock bias, from .clk data\n",
-    "clkdata_gps = parse_clockfile(\"grg21553_short.clk\", constellation = 'gps')"
-   ]
-  },
-  {
-   "cell_type": "code",
-   "execution_count": null,
-   "id": "cda1a4a3",
-   "metadata": {},
-   "outputs": [],
-   "source": [
-    "# Update derived_data_gps class with satellite information computed via precise ephemerides\n",
-    "derived_multi_gnss = compute_sv_gnss_from_precise_eph(derived_data_gps, sp3data_gps, \\\n",
-    "                                                      clkdata_gps, verbose = False)"
-   ]
   }
  ],
  "metadata": {
   "kernelspec": {
-   "display_name": "Python 3 (ipykernel)",
+   "display_name": "Python 3",
    "language": "python",
    "name": "python3"
   },
@@ -221,7 +141,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.8.10"
+   "version": "3.8.9"
   },
   "vscode": {
    "interpreter": {