assert type checks

Author: betaBison

gnss_lib_py/utils/sv_models.py

@@ -616,9 +616,9 @@ def _filter_ephemeris_measurements(measurements, constellations,
     """
     measurements.in_rows(['gnss_id', 'sv_id', 'gps_millis'])
     # Check whether the rows are in the right format as needed.
-    isinstance(measurements['gnss_id'].dtype, object)
-    isinstance(measurements['sv_id'].dtype, int)
-    isinstance(measurements['gps_millis'].dtype, np.int64)
+    assert isinstance(measurements['gnss_id'].dtype, object)
+    assert np.issubdtype(measurements['sv_id'].dtype, np.integer)
+    assert np.issubdtype(measurements['gps_millis'].dtype, float)
     rx_const= np.unique(measurements['gnss_id'])
     # Check if required constellations are available, keep only required
     # constellations

tests/parsers/test_android.py

@@ -189,10 +189,10 @@ def test_sensor_loaders(raw_path, sensor_type):
     """
 
     test_navdata = sensor_type(input_path = raw_path)
-    isinstance(test_navdata, NavData)
+    assert isinstance(test_navdata, NavData)
 
     test_navdata = sensor_type(pathlib.Path(raw_path))
-    isinstance(test_navdata, NavData)
+    assert isinstance(test_navdata, NavData)
 
     # raises exception if not a file path
     with pytest.raises(FileNotFoundError):
@@ -286,10 +286,10 @@ def test_fix_raw(android_raw_path):
         Path to Android Raw measurements text log file
     """
     test_fix = android.AndroidRawFixes(android_raw_path)
-    isinstance(test_fix, NavData)
+    assert isinstance(test_fix, NavData)
 
     test_fix = android.AndroidRawFixes(pathlib.Path(android_raw_path))
-    isinstance(test_fix, NavData)
+    assert isinstance(test_fix, NavData)
 
     # raises exception if not a file path
     with pytest.raises(FileNotFoundError):

tests/parsers/test_google_decimeter.py

@@ -338,8 +338,8 @@ def test_navdata_type(derived):
     derived : pytest.fixture
         Instance of AndroidDerived2021 for testing
     """
-    isinstance(derived, NavData)
-    isinstance(derived, google_decimeter.AndroidDerived2021)
+    assert isinstance(derived, NavData)
+    assert isinstance(derived, google_decimeter.AndroidDerived2021)
 
 def test_timestep_parsing(derived_path_xl):
     """Test that the timesteps contain the same satellites.
@@ -442,8 +442,8 @@ def test_android_gtruth(gtruth):
 
     """
 
-    isinstance(gtruth, NavData)
-    isinstance(gtruth, google_decimeter.AndroidGroundTruth2021)
+    assert isinstance(gtruth, NavData)
+    assert isinstance(gtruth, google_decimeter.AndroidGroundTruth2021)
 
     assert int(gtruth["gps_millis",3]) == 1273529466442
 

tests/parsers/test_smartloc.py

@@ -193,8 +193,8 @@ def test_navdata_type(smartloc_raw):
     smartloc_raw : pytest.fixture
         Instance of SmartLocRaw for testing
     """
-    isinstance(smartloc_raw, NavData)
-    isinstance(smartloc_raw, SmartLocRaw)
+    assert isinstance(smartloc_raw, NavData)
+    assert isinstance(smartloc_raw, SmartLocRaw)
 
 
 def test_shape_update(smartloc_raw):