fix url, standardize standard/navlab devel guide

Author: betaBison

docs/source/contributing/development.rst

@@ -14,26 +14,24 @@ Standard GitHub Workflow
 ------------------------
 
 1. Fork `gnss_lib_py <https://github.com/Stanford-NavLab/gnss_lib_py>`__
-   (look for the "Fork" button).
-
-2. Clone your fork locally:
+   (look for the "Fork" button), then clone your fork locally:
 
    .. code-block:: bash
 
       git clone https://github.com/<your username>/gnss_lib_py
 
-3. If using poetry, follow the :ref:`developer install instructions<developer install>`
+2. If using poetry, follow the :ref:`developer install instructions<developer install>`
    to install pyenv, poetry, and the python dependencies. If using
    :code:`pip` or :code:`conda` for package management instead, use
    :code:`pip install -r requirements.txt` to install dependencies.
 
-4. Create a local branch:
+3. Create a local branch:
 
    .. code-block:: bash
 
       git checkout -b your-name/name-of-your-bugfix-or-feature
 
-5. Make changes locally and document them appropriately. See the
+4. Make changes locally and document them appropriately. See the
    :ref:`Documentation<documentation>` section for more details.
 
    If the feature branch includes new functionality, you must also:
@@ -44,18 +42,18 @@ Standard GitHub Workflow
    * add a section in the appropriate tutorial notebook located in
      :code:`notebooks/tutorials/*`
 
-6. Add tests for the newly added code and ensure the new code is covered.
+5. Add tests for the newly added code and ensure the new code is covered.
    See the :ref:`Testing<testing>` section for more details.
 
-7. When you're done making changes run all the tests with:
+6. When you're done making changes run all the tests with:
 
    .. code-block:: bash
 
       poetry run pytest
 
    Make sure that all tests are passing.
 
-8. Verify that testing coverage has not decreased:
+7. Verify that testing coverage has not decreased:
 
    .. code-block:: bash
 
@@ -64,7 +62,7 @@ Standard GitHub Workflow
 
    See the :ref:`Coverage Report<coverage>` section for more details.
 
-9. Improve code readability by linting it. Run :code:`pylint` to preview
+8. Improve code readability by linting it. Run :code:`pylint` to preview
    issues with the code:
 
    .. code-block:: bash
@@ -75,11 +73,22 @@ Standard GitHub Workflow
    such as conforming to snake case naming, removing TODOs and using suggested
    defaults.
 
-10. Ensure that system and IDE dependent files, like those in :code:`.idea`
-    folders for PyCharm and :code:`.vscode` folders for VS Code are not
-    committed by updating the :code:`.gitignore` file.
+9. Ensure that system and IDE dependent files, like those in :code:`.idea`
+   folders for PyCharm and :code:`.vscode` folders for VS Code are not
+   committed by updating the :code:`.gitignore` file.
+
+10. Improve code readability by linting it. Run :code:`pylint` to preview
+    issues with the code:
+
+    .. code-block:: bash
+
+       poetry run python -m pylint path-to-file-to-lint
+
+    Resolve issues that do not impact how you have implemented your functionality,
+    such as conforming to snake case naming, removing TODOs and using suggested
+    defaults.
 
-11. Add your name to the `contributors list <https://github.com/Stanford-NavLab/gnss_lib_py/blob/main/CONTRIBUTORS.sh>`__.
+11. Add your name to the `contributors list <https://github.com/Stanford-NavLab/gnss_lib_py/blob/main/CONTRIBUTORS.md>`__.
 
 12. Commit your changes and publish your branch to GitHub:
 
@@ -89,7 +98,13 @@ Standard GitHub Workflow
       git commit -m "<describe changes in this commit>"
       git push origin your-name/name-of-your-bugfix-or-feature
 
-13. Submit a pull request through GitHub.
+13. Submit a pull request through GitHub. For the base branch
+    in the pull request, select the latest version release branch :code:`vx.Y.Z`
+    (with the highest number of all such branches). *Do not target the*
+    :code:`main` *branch in your pull request.* In the pull request,
+    add a code review request for a current maintainer of the repository.
+    The reviewers might add comments to ensure compliance with the rest
+    of the code.
 
 .. _navlab_dev:
 
@@ -119,15 +134,16 @@ NAVLab GitHub Workflow
    * add a section in the appropriate tutorial notebook located in
      :code:`notebooks/tutorials/*`
 
-5. Add your name to the `contributors list <https://github.com/Stanford-NavLab/gnss_lib_py/blob/main/CONTRIBUTORS.sh>`__.
+5. Add tests for the newly added code and ensure the new code is covered.
+   See the :ref:`Testing<testing>` section for more details.
 
 6. When you're done making changes run all the tests with:
 
    .. code-block:: bash
 
       poetry run pytest
 
-   See the :ref:`Testing<testing>` section for more details.
+   Make sure that all tests are passing.
 
 7. Verify that testing coverage has not decreased:
 
@@ -138,11 +154,7 @@ NAVLab GitHub Workflow
 
    See the :ref:`Coverage Report<coverage>` section for more details.
 
-8. Ensure that system and IDE dependent files, like those in :code:`.idea`
-   folders for PyCharm and :code:`.vscode` folders for VS Code are not
-   committed by updating the :code:`.gitignore` file.
-
-9. Improve code readability by linting it. Run :code:`pylint` to preview
+8. Improve code readability by linting it. Run :code:`pylint` to preview
    issues with the code:
 
    .. code-block:: bash
@@ -153,7 +165,24 @@ NAVLab GitHub Workflow
    such as conforming to snake case naming, removing TODOs and using suggested
    defaults.
 
-10. When you're ready to commit changes follow the steps below to
+9. Ensure that system and IDE dependent files, like those in :code:`.idea`
+   folders for PyCharm and :code:`.vscode` folders for VS Code are not
+   committed by updating the :code:`.gitignore` file.
+
+10. Improve code readability by linting it. Run :code:`pylint` to preview
+    issues with the code:
+
+    .. code-block:: bash
+
+       poetry run python -m pylint path-to-file-to-lint
+
+    Resolve issues that do not impact how you have implemented your functionality,
+    such as conforming to snake case naming, removing TODOs and using suggested
+    defaults.
+
+11. Add your name to the `contributors list <https://github.com/Stanford-NavLab/gnss_lib_py/blob/main/CONTRIBUTORS.md>`__.
+
+12. When you're ready to commit changes follow the steps below to
     minimize unnecessary merging. This is especially important if
     multiple people are working on the same branch. If you pull new
     changes, then repeat the tests above to double check that everything
@@ -168,13 +197,13 @@ NAVLab GitHub Workflow
       git commit -m "<describe changes in this commit>"
       git push origin your-name/name-of-your-bugfix-or-feature
 
-11. Submit a pull request through the GitHub website. For the base branch
+13. Submit a pull request through GitHub. For the base branch
     in the pull request, select the latest version release branch :code:`vx.Y.Z`
     (with the highest number of all such branches). *Do not target the*
     :code:`main` *branch in your pull request.* In the pull request,
-    add a code review request for the current maintainers of the repository,
-    Ashwin Kanhere or Derek Knowles. The reviewers
-    might add comments to ensure compliance with the rest of the code.
+    add a code review request for a current maintainer of the repository.
+    The reviewers might add comments to ensure compliance with the rest
+    of the code.
 
 .. _pr_review: