combine error messages in solve_wls

Author: betaBison

gnss_lib_py/algorithms/snapshot.py

@@ -84,6 +84,7 @@ def solve_wls(measurements, weight_type = None, only_bias = False,
                                                rx_rows_to_find,
                                                max_allow=1)
     states = []
+    runtime_error_idxs = {}
 
     position = np.zeros((4,1))
     for timestamp, _, measurement_subset in measurements.loop_time("gps_millis", delta_t_decimals=delta_t_decimals):
@@ -120,9 +121,10 @@ def solve_wls(measurements, weight_type = None, only_bias = False,
                            only_bias, tol, max_count)
             states.append([timestamp] + np.squeeze(position).tolist())
         except RuntimeError as error:
-            warnings.warn("RuntimeError encountered at gps_millis: " \
-                        + str(int(timestamp)) + " RuntimeError: " \
-                        + str(error), RuntimeWarning)
+            if str(error) not in runtime_error_idxs:
+                runtime_error_idxs[str(error)] = [str(int(timestamp))]
+            else:
+                runtime_error_idxs[str(error)].append(str(int(timestamp)))
             states.append([timestamp, np.nan, np.nan, np.nan, np.nan])
 
     states = np.array(states)
@@ -134,6 +136,11 @@ def solve_wls(measurements, weight_type = None, only_bias = False,
     state_estimate["z_rx_wls_m"] = states[:,3]
     state_estimate["b_rx_wls_m"] = states[:,4]
 
+    for error,timestamps in runtime_error_idxs.items():
+        warnings.warn(error + " Encountered at " + str(len(timestamps))\
+                    + " gps_millis of: " \
+                + ", ".join(timestamps), RuntimeWarning)
+
     if np.isnan(states[:,1:]).all():
         warnings.warn("No valid state estimate computed in WLS, "\
                     + "returning NaNs.", RuntimeWarning)

gnss_lib_py/parsers/navdata.py

@@ -373,7 +373,7 @@ def argwhere(self, key_idx, value, condition="eq"):
             elif np.isnan(value):
                 str_check = [str(np.nan)]
             else:
-                raise ValueError("Value must be string or array-like" \
+                raise ValueError("Value must be string or array-like " \
                                + "for string condition checks")
             # Extract columns where condition holds true and return new NavData
             if condition == "eq":

tests/algorithms/test_snapshot.py

@@ -592,7 +592,8 @@ def test_solve_wls_fails(derived):
 
     """
 
-    navdata = derived.remove(cols=list(range(3,len(derived))))
+    navdata = derived.remove(cols=list(range(3,50)) \
+                                + list(range(53,len(derived))))
 
     with pytest.warns(RuntimeWarning) as warns:
         solve_wls(navdata)