Skip to content

Commit 0db8136

Browse files
committed
altitude is in meters, thanks daniel
1 parent d9d3bad commit 0db8136

6 files changed

Lines changed: 8 additions & 8 deletions

File tree

gnss_lib_py/algorithms/gnss_filters.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ def solve_gnss_ekf(measurements, init_dict = None,
134134
"z_rx_ekf_m"]].reshape(3,-1))
135135
state_estimate["lat_rx_ekf_deg"] = lat
136136
state_estimate["lon_rx_ekf_deg"] = lon
137-
state_estimate["alt_rx_ekf_deg"] = alt
137+
state_estimate["alt_rx_ekf_m"] = alt
138138

139139
return state_estimate
140140

gnss_lib_py/algorithms/snapshot.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ def solve_wls(measurements, weight_type = None, only_bias = False,
7070
the NavData class with shape (4 x # unique timesteps) and
7171
the following rows: gps_millis, x_rx_wls_m, y_rx_wls_m,
7272
z_rx_wls_m, b_rx_wls_m, lat_rx_wls_deg, lon_rx_wls_deg,
73-
alt_rx_wls_deg.
73+
alt_rx_wls_m.
7474
7575
"""
7676

@@ -154,7 +154,7 @@ def solve_wls(measurements, weight_type = None, only_bias = False,
154154
"z_rx_wls_m"]].reshape(3,-1))
155155
state_estimate["lat_rx_wls_deg"] = lat
156156
state_estimate["lon_rx_wls_deg"] = lon
157-
state_estimate["alt_rx_wls_deg"] = alt
157+
state_estimate["alt_rx_wls_m"] = alt
158158

159159
return state_estimate
160160

gnss_lib_py/parsers/android.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -597,7 +597,7 @@ def solve_kaggle_baseline(navdata):
597597
data_df["unix_millis"].to_numpy())
598598
state_estimate["lat_rx_deg"] = lat
599599
state_estimate["lon_rx_deg"] = lon
600-
state_estimate["alt_rx_deg"] = alt
600+
state_estimate["alt_rx_m"] = alt
601601

602602
return state_estimate
603603

tests/algorithms/test_gnss_filters.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ def test_solve_gnss_ekf(derived):
187187
assert "b_rx_ekf_m" in state_estimate.rows
188188
assert "lat_rx_ekf_deg" in state_estimate.rows
189189
assert "lon_rx_ekf_deg" in state_estimate.rows
190-
assert "alt_rx_ekf_deg" in state_estimate.rows
190+
assert "alt_rx_ekf_m" in state_estimate.rows
191191

192192
# should have the same length as the number of unique timesteps
193193
assert len(state_estimate) == sum(1 for _ in derived.loop_time("gps_millis"))

tests/algorithms/test_snapshot.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,7 @@ def test_solve_wls(derived):
378378
assert "b_rx_wls_m" in state_estimate.rows
379379
assert "lat_rx_wls_deg" in state_estimate.rows
380380
assert "lon_rx_wls_deg" in state_estimate.rows
381-
assert "alt_rx_wls_deg" in state_estimate.rows
381+
assert "alt_rx_wls_m" in state_estimate.rows
382382

383383
# should have the same length as the number of unique timesteps
384384
assert len(state_estimate) == sum(1 for _ in derived.loop_time("gps_millis"))
@@ -551,7 +551,7 @@ def test_solve_wls_bias_only(derived_2022):
551551
assert "b_rx_wls_m" in state_estimate.rows
552552
assert "lat_rx_wls_deg" in state_estimate.rows
553553
assert "lon_rx_wls_deg" in state_estimate.rows
554-
assert "alt_rx_wls_deg" in state_estimate.rows
554+
assert "alt_rx_wls_m" in state_estimate.rows
555555

556556
# should have the same length as the number of unique timesteps
557557
assert len(state_estimate) == time_length

tests/parsers/test_android.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -739,7 +739,7 @@ def test_solve_kaggle_baseline(derived_2022):
739739
state_estimate = android.solve_kaggle_baseline(derived_2022)
740740

741741
state_estimate.in_rows(["gps_millis","lat_rx_deg",
742-
"lon_rx_deg","alt_rx_deg"])
742+
"lon_rx_deg","alt_rx_m"])
743743

744744
assert state_estimate.shape[1] == 6
745745

0 commit comments

Comments
 (0)