SONARJAVA-5340 FP on S1171 in anonymous classes (#5411)

Author: asya-vorobeva

java-checks-test-sources/default/src/main/java/checks/NonStaticClassInitializerCheckSample.java

@@ -4,6 +4,11 @@ class NonStaticClassInitializerCheckSample {
   static {
   }
 
+  static class Inner {
+    { // Noncompliant
+    }
+  }
+
   { // Noncompliant {{Move the contents of this initializer to a standard constructor or to field initializers.}}
 //^
     System.out.println();
@@ -14,7 +19,7 @@ public NonStaticClassInitializerCheckSample() {
 
     new Runnable() {
 
-      { // Noncompliant
+      {
         System.out.println();
       }
 

java-checks/src/main/java/org/sonar/java/checks/NonStaticClassInitializerCheck.java

@@ -34,6 +34,13 @@ public List<Tree.Kind> nodesToVisit() {
 
   @Override
   public void visitNode(Tree tree) {
-    reportIssue(((BlockTree) tree).openBraceToken(), "Move the contents of this initializer to a standard constructor or to field initializers.");
+    if (!isMemberOfAnonymousClass(tree)) {
+      reportIssue(((BlockTree) tree).openBraceToken(), "Move the contents of this initializer to a standard constructor or to field initializers.");
+    }
+  }
+
+  private static boolean isMemberOfAnonymousClass(Tree tree) {
+    Tree parent = tree.parent();
+    return parent.is(Tree.Kind.CLASS) && parent.parent() != null && parent.parent().is(Tree.Kind.NEW_CLASS);
   }
 }