SONARJAVA-6086 S1172 should raise on main in Java 25 (#5450)

Author: tomasz-tylenda-sonarsource

…s/unused/UnusedMethodParameterCheck.java …ed/UnusedMethodParameterCheckSample.javajava-checks-test-sources/default/src/main/files/non-compiling/checks/unused/UnusedMethodParameterCheck.java renamed to java-checks-test-sources/default/src/main/files/non-compiling/checks/unused/UnusedMethodParameterCheckSample.java java-checks-test-sources/default/src/main/files/non-compiling/checks/unused/UnusedMethodParameterCheck.java renamed to java-checks-test-sources/default/src/main/files/non-compiling/checks/unused/UnusedMethodParameterCheckSample.java

@@ -0,0 +1,11 @@
+package checks.unused;
+
+public class UnusedMethodParameterCheckMainSample {
+  public static void main(String[] args) { // Noncompliant {{Remove this unused method parameter "args".}}
+    System.out.println("Hello World!");
+  }
+
+  void main() { // Compliant
+    System.out.println("Hello World!");
+  }
+}

java-checks-test-sources/default/src/main/java/checks/unused/UnusedMethodParameterCheckMainSample.java

@@ -33,6 +33,7 @@
 import org.sonar.java.reporting.JavaTextEdit;
 import org.sonar.plugins.java.api.IssuableSubscriptionVisitor;
 import org.sonar.plugins.java.api.JavaFileScannerContext;
+import org.sonar.plugins.java.api.JavaVersion;
 import org.sonar.plugins.java.api.semantic.MethodMatchers;
 import org.sonar.plugins.java.api.semantic.Symbol;
 import org.sonar.plugins.java.api.semantic.SymbolMetadata;
@@ -159,14 +160,23 @@ private static List<JavaQuickFix> createQuickFixes(MethodTree methodTree, List<I
   }
 
   private boolean isExcluded(MethodTree tree) {
-    return MethodTreeUtils.isMainMethod(tree, context.getJavaVersion())
+    return isMainWithRequiredArgs(tree)
       || isAnnotated(tree)
       || isOverriding(tree)
       || isSerializableMethod(tree)
       || isDesignedForExtension(tree)
       || isUsedAsMethodReference(tree);
   }
 
+  /**
+   * True if the argument is the main method and the argument cannot be removed,
+   * which is the case before Java 25.
+   */
+  private boolean isMainWithRequiredArgs(MethodTree tree) {
+    JavaVersion javaVersion = context.getJavaVersion();
+    return !javaVersion.isJava25Compatible() && MethodTreeUtils.isMainMethod(tree, javaVersion);
+  }
+
   private static boolean isAnnotated(MethodTree tree) {
     // If any annotation doesn't match the @SuppressWarning then mark the method as annotated.
     return tree.modifiers().annotations().stream().anyMatch(annotation -> !isExcludedLiteral(annotation));

…s/unused/UnusedMethodParameterCheck.java …ed/UnusedMethodParameterCheckSample.javajava-checks-test-sources/default/src/main/java/checks/unused/UnusedMethodParameterCheck.java renamed to java-checks-test-sources/default/src/main/java/checks/unused/UnusedMethodParameterCheckSample.java java-checks-test-sources/default/src/main/java/checks/unused/UnusedMethodParameterCheck.java renamed to java-checks-test-sources/default/src/main/java/checks/unused/UnusedMethodParameterCheckSample.java

@@ -18,25 +18,45 @@
 
 import org.junit.jupiter.api.Test;
 import org.sonar.java.checks.verifier.CheckVerifier;
+import org.sonar.plugins.java.api.JavaFileScanner;
 
 import static org.sonar.java.checks.verifier.TestUtils.mainCodeSourcesPath;
 import static org.sonar.java.checks.verifier.TestUtils.nonCompilingTestSourcesPath;
 
 class UnusedMethodParameterCheckTest {
+  private static final JavaFileScanner CHECK = new UnusedMethodParameterCheck();
 
   @Test
   void test() {
     CheckVerifier.newVerifier()
-      .onFile(mainCodeSourcesPath("checks/unused/UnusedMethodParameterCheck.java"))
-      .withCheck(new UnusedMethodParameterCheck())
+      .onFile(mainCodeSourcesPath("checks/unused/UnusedMethodParameterCheckSample.java"))
+      .withCheck(CHECK)
+      .verifyIssues();
+  }
+
+  @Test
+  void test_main_method_java21() {
+    CheckVerifier.newVerifier()
+      .onFile(mainCodeSourcesPath("checks/unused/UnusedMethodParameterCheckMainSample.java"))
+      .withCheck(CHECK)
+      .withJavaVersion(21)
+      .verifyNoIssues();
+  }
+
+  @Test
+  void test_main_method_java25() {
+    CheckVerifier.newVerifier()
+      .onFile(mainCodeSourcesPath("checks/unused/UnusedMethodParameterCheckMainSample.java"))
+      .withCheck(CHECK)
+      .withJavaVersion(25)
       .verifyIssues();
   }
 
   @Test
   void test_non_compiling() {
     CheckVerifier.newVerifier()
-      .onFile(nonCompilingTestSourcesPath("checks/unused/UnusedMethodParameterCheck.java"))
-      .withCheck(new UnusedMethodParameterCheck())
+      .onFile(nonCompilingTestSourcesPath("checks/unused/UnusedMethodParameterCheckSample.java"))
+      .withCheck(CHECK)
       .verifyIssues();
   }
 }