SONARJAVA-6016 Migrate the Guava project in the ruling tests to Java 21 (#5459)

Author: aurelien-coet-sonarsource

.github/workflows/build.yml

@@ -57,10 +57,8 @@ jobs:
         item:
           - { runner: github-ubuntu-latest-m, profile: without-sonarqube-project }
           - { runner: github-ubuntu-latest-m, profile: only-sonarqube-project }
-          - { runner: github-ubuntu-latest-m, profile: only-guava-project, java_version: 17, sonar-runtime: "LATEST_RELEASE[2025.4]" }
           - { runner: github-windows-latest-m, profile: without-sonarqube-project }
           - { runner: github-windows-latest-m, profile: only-sonarqube-project }
-          - { runner: github-windows-latest-m, profile: only-guava-project, java_version: 17, sonar-runtime: "LATEST_RELEASE[2025.4]" }
     name: Ruling QA
     needs:
       - build
@@ -79,9 +77,7 @@ jobs:
         with:
           version: 2025.7.12
       - name: Select Java Version
-        env:
-          JAVA_VERSION: ${{ matrix.item.java_version || '21' }}
-        run: mise use "java@${{ env.JAVA_VERSION }}"
+        run: mise use java@21
       - name: Configure Maven
         uses: SonarSource/ci-github-actions/config-maven@v1
         with:
@@ -99,10 +95,9 @@ jobs:
         env:
           MAVEN_OPTS: "-Xmx3g"
           GITHUB_TOKEN: ${{ fromJSON(steps.secrets.outputs.vault).GITHUB_TOKEN }}
-          SONAR_RUNTIME: ${{ matrix.item.sonar-runtime || 'LATEST_RELEASE' }}
         run: |
           cd its/ruling
-          mvn package --batch-mode "-Pit-ruling,${{ matrix.item.profile }}" "-Dsonar.runtimeVersion=${{ env.SONAR_RUNTIME }}" -Dmaven.test.redirectTestOutputToFile=false -B -e -V -Dparallel=methods -DuseUnlimitedThreads=true
+          mvn package --batch-mode "-Pit-ruling,${{ matrix.item.profile }}" -Dsonar.runtimeVersion=LATEST_RELEASE -Dmaven.test.redirectTestOutputToFile=false -B -e -V -Dparallel=methods -DuseUnlimitedThreads=true
 
   plugin-qa:
     strategy:

its/ruling/pom.xml

@@ -108,7 +108,7 @@
             <groupId>org.apache.maven.plugins</groupId>
             <artifactId>maven-surefire-plugin</artifactId>
             <configuration>
-              <test>!org.sonar.java.it.JavaRulingTest#sonarqube_server,!org.sonar.java.it.JavaRulingTest#guava</test>
+              <test>!org.sonar.java.it.JavaRulingTest#sonarqube_server</test>
             </configuration>
           </plugin>
         </plugins>
@@ -128,20 +128,6 @@
         </plugins>
       </build>
     </profile>
-    <profile>
-      <id>only-guava-project</id>
-      <build>
-        <plugins>
-          <plugin>
-            <groupId>org.apache.maven.plugins</groupId>
-            <artifactId>maven-surefire-plugin</artifactId>
-            <configuration>
-              <test>org.sonar.java.it.JavaRulingTest#guava</test>
-            </configuration>
-          </plugin>
-        </plugins>
-      </build>
-    </profile>
   </profiles>
 
 </project>

its/ruling/src/test/java/org/sonar/java/it/JavaRulingTest.java

@@ -185,8 +185,8 @@ public void guava() throws Exception {
     String projectName = "guava";
     MavenBuild build = test_project("com.google.guava:guava", projectName);
     build
-      // by default guava is compatible with java 6, however this is not supported with JDK 17
-      .setProperty("java.version", "1.7")
+      // by default guava is compatible with java 6, however this is not supported with JDK 21
+      .setProperty("java.version", "1.8")
       .setProperty("maven.javadoc.skip", "true")
       // use batch
       .setProperty("sonar.java.experimental.batchModeSizeInKB", "8192");

its/ruling/src/test/resources/guava/java-S109.json

@@ -80,8 +80,8 @@
 260
 ],
 "com.google.guava:guava:src/com/google/common/collect/Collections2.java": [
-317,
-524
+316,
+523
 ],
 "com.google.guava:guava:src/com/google/common/collect/EnumHashBiMap.java": [
 122,

its/ruling/src/test/resources/guava/java-S1108.json

@@ -218,10 +218,10 @@
 32
 ],
 "com.google.guava:guava:src/com/google/common/collect/Collections2.java": [
-111,
-113,
-127,
-129
+110,
+112,
+126,
+128
 ],
 "com.google.guava:guava:src/com/google/common/collect/ComputingConcurrentHashMap.java": [
 112,

its/ruling/src/test/resources/guava/java-S1120.json

@@ -3451,104 +3451,104 @@
 49
 ],
 "com.google.guava:guava:src/com/google/common/collect/Collections2.java": [
-59,
-93,
-96,
-108,
-110,
-112,
-114,
-124,
-126,
-128,
-130,
+58,
+92,
+95,
+107,
+109,
+111,
+113,
+123,
+125,
+127,
+129,
+133,
 134,
-135,
-139,
-144,
-150,
+138,
+143,
+149,
+155,
 156,
-157,
-164,
-169,
-171,
-179,
-184,
-189,
-194,
-199,
-204,
-209,
-215,
-220,
-245,
+163,
+168,
+170,
+178,
+183,
+188,
+193,
+198,
+203,
+208,
+214,
+219,
+244,
+247,
 248,
-249,
-253,
-259,
-264,
-269,
-274,
-291,
-298,
+252,
+258,
+263,
+268,
+273,
+290,
+297,
+304,
 305,
-306,
-316,
-324,
-359,
-412,
+315,
+323,
+358,
+411,
+414,
 415,
-416,
-421,
-437,
-441,
-444,
-447,
-455,
-462,
-467,
-472,
+420,
+436,
+440,
+443,
+446,
+454,
+461,
+466,
+471,
+476,
 477,
-478,
-486,
-490,
-492,
-496,
+485,
+489,
+491,
+495,
+501,
 502,
-503,
-511,
-513,
+510,
+512,
+523,
 524,
 525,
-526,
-533,
+532,
+534,
 535,
-536,
-565,
+564,
+567,
 568,
-569,
-572,
-577,
-582,
-587,
+571,
+576,
+581,
+586,
+591,
 592,
-593,
-601,
+600,
+604,
 605,
-606,
-612,
+611,
+622,
 623,
-624,
-632,
-638,
-642,
-644,
+631,
+637,
+641,
+643,
+647,
 648,
-649,
-663,
+662,
+671,
 672,
-673,
-681
+680
 ],
 "com.google.guava:guava:src/com/google/common/collect/ComparatorOrdering.java": [
 31,

its/ruling/src/test/resources/guava/java-S1135.json

@@ -74,7 +74,7 @@
 167
 ],
 "com.google.guava:guava:src/com/google/common/collect/Collections2.java": [
-89
+88
 ],
 "com.google.guava:guava:src/com/google/common/collect/ComputingConcurrentHashMap.java": [
 353

its/ruling/src/test/resources/guava/java-S1166.json

@@ -34,10 +34,10 @@
 60
 ],
 "com.google.guava:guava:src/com/google/common/collect/Collections2.java": [
-111,
-113,
-127,
-129
+110,
+112,
+126,
+128
 ],
 "com.google.guava:guava:src/com/google/common/collect/ConcurrentHashMultiset.java": [
 244

its/ruling/src/test/resources/guava/java-S1213.json

@@ -318,7 +318,7 @@
 52
 ],
 "com.google.guava:guava:src/com/google/common/collect/Collections2.java": [
-327
+326
 ],
 "com.google.guava:guava:src/com/google/common/collect/ComparatorOrdering.java": [
 64

its/ruling/src/test/resources/guava/java-S1309.json

@@ -73,7 +73,7 @@
 358
 ],
 "com.google.guava:guava:src/com/google/common/collect/Collections2.java": [
-170
+169
 ],
 "com.google.guava:guava:src/com/google/common/collect/ComparisonChain.java": [
 79