SONARJAVA-5929 S1258 FP on Spring @value annotation (#5393)

Author: aurelien-coet-sonarsource

java-checks-test-sources/default/src/main/files/non-compiling/checks/AtLeastOneConstructorCheckSample.java

@@ -9,3 +9,8 @@ class AtLeastOneConstructorCheckSample {
 class AtLeastOneConstructorCheckAnnotatedUnknown  {
   private MyObject foo; // Compliant
 }
+
+class WithValueAnnotation {
+  @Value("${app.field}")
+  private int field; // Compliant
+}

java-checks-test-sources/default/src/main/java/checks/AtLeastOneConstructorCheckSample.java

@@ -16,6 +16,7 @@
 import org.apache.maven.plugins.annotations.Parameter;
 import org.codehaus.plexus.component.annotations.Configuration;
 import org.codehaus.plexus.component.annotations.Requirement;
+import org.springframework.beans.factory.annotation.Value;
 
 class WithoutConstructor { // Noncompliant {{Add a constructor to the class, or provide default values.}}
 //    ^^^^^^^^^^^^^^^^^^
@@ -163,3 +164,13 @@ class MyLombok { // Compliant, Builder pattern are excluded (Lombok builder)
 
   public int getField(){return field;}
 }
+
+class WithValueAnnotation { // Compliant, fields annotated with Spring @Value are excluded
+  @Value("${app.field}")
+  private int field;
+}
+
+class WithValueAnnotationDefault { // Compliant, fields annotated with Spring @Value are excluded
+  @Value("${app.field:10}")
+  private int field;
+}

java-checks/src/main/java/org/sonar/java/checks/AtLeastOneConstructorCheck.java

@@ -57,7 +57,8 @@ public class AtLeastOneConstructorCheck extends IssuableSubscriptionVisitor {
     "org.apache.maven.plugins.annotations.Component",
     "org.apache.maven.plugins.annotations.Parameter",
     "org.codehaus.plexus.component.annotations.Requirement",
-    "org.codehaus.plexus.component.annotations.Configuration"
+    "org.codehaus.plexus.component.annotations.Configuration",
+    "org.springframework.beans.factory.annotation.Value"
     );
 
   @Override