SONARJAVA-6119 S3078 report on compact source files (#5456)

Author: tomasz-tylenda-sonarsource

java-checks-test-sources/default/src/main/java/checks/VolatileVariablesOperationsCheck.java

@@ -109,3 +109,25 @@ void method() {
     value++; // Noncompliant
   }
 }
+
+record Vinyl(String singer, String title, int year) {
+  static volatile int counter = 0;
+  static int nonVolatile = 0;
+
+  void method() {
+    counter++; // Noncompliant
+    nonVolatile++;
+  }
+}
+
+class Container {
+  static volatile int counter = 0;
+  static int nonVolatile = 0;
+}
+
+interface MyInterface {
+  default void method() {
+    Container.counter++; // Noncompliant
+    Container.nonVolatile++;
+  }
+}

java-checks-test-sources/default/src/main/java/checks/VolatileVariablesOperationsCheckCompactSource.java

@@ -0,0 +1,9 @@
+volatile int count1 = 0;
+int nonVolatileCount1 = 0;
+volatile boolean boo1 = false;
+
+void main() {
+  count1++; // Noncompliant {{Use an "AtomicInteger" for this field; its operations are atomic.}}
+  nonVolatileCount1++;
+  boo1 = !boo1; // Noncompliant {{Use an "AtomicBoolean" for this field; its operations are atomic.}}
+}

java-checks/src/main/java/org/sonar/java/checks/VolatileVariablesOperationsCheck.java

@@ -125,13 +125,17 @@ private void reportIssueIfNotInExcludedContext(Tree tree, String recommendedType
           }
           break;
         case ENUM,
-          CLASS:
-          if (((ClassTree) current).simpleName() == null) {
+          CLASS,
+          INTERFACE,
+          RECORD,
+          IMPLICIT_CLASS:
+          if (!current.is(Tree.Kind.IMPLICIT_CLASS) && ((ClassTree) current).simpleName() == null) {
             return;
           }
-          // we got to a non anonymous class, we can safely raise an issue
+          // we got to a non-anonymous class or implicit class in compact source file, we can safely raise an issue
           foundClass = true;
           break;
+
       }
       current = current.parent();
     }

java-checks/src/test/java/org/sonar/java/checks/VolatileVariablesOperationsCheckTest.java

@@ -30,4 +30,12 @@ void test() {
       .withCheck(new VolatileVariablesOperationsCheck())
       .verifyIssues();
   }
+
+  @Test
+  void test_compact_source() {
+    CheckVerifier.newVerifier()
+      .onFile(mainCodeSourcesPath("checks/VolatileVariablesOperationsCheckCompactSource.java"))
+      .withCheck(new VolatileVariablesOperationsCheck())
+      .verifyIssues();
+  }
 }