Skip to content

Commit 2f9782b

Browse files
authored
SONARJAVA-6289 Fix QG / Fix issues with stream().foreach(...) (#5585)
1 parent 6bbe2f5 commit 2f9782b

3 files changed

Lines changed: 3 additions & 6 deletions

File tree

java-checks/src/test/java/org/sonar/java/checks/helpers/ValueBasedUtilsTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,7 @@ void testIsValueBased() {
3636
CompilationUnitTree tree = JParserTestUtils.parse(file);
3737

3838
List<Tree> members = ((ClassTree) tree.types().get(0)).members();
39-
members.stream()
40-
.forEach(member -> checkMember((VariableTree)member));
39+
members.forEach(member -> checkMember((VariableTree)member));
4140
}
4241

4342
private static void checkMember(VariableTree member) {

java-frontend/src/main/java/org/sonar/java/SonarComponents.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -606,7 +606,7 @@ public InputComponent project() {
606606
}
607607

608608
public void collectUndefinedTypes(String pathToFile, Set<JProblem> undefinedTypes) {
609-
undefinedTypes.stream().forEach(problem -> {
609+
undefinedTypes.forEach(problem -> {
610610
List<String> filesAffectedByProblem = problemsToFilePaths.computeIfAbsent(problem, key -> new ArrayList<>());
611611
filesAffectedByProblem.add(pathToFile);
612612
});

java-frontend/src/main/java/org/sonar/java/model/DefaultJavaFileScannerContext.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,9 +108,7 @@ public void reportIssue(RegexCheck regexCheck, RegexSyntaxElement regexTree, Str
108108
List<RegexCheck.RegexIssueLocation> mainLocations = new RegexCheck.RegexIssueLocation(regexTree, message).toSingleLocationItems();
109109
if (mainLocations.size() > 1) {
110110
// handle other main locations as secondaries with same message
111-
mainLocations.subList(1, mainLocations.size())
112-
.stream()
113-
.forEach(completedSecondaries::add);
111+
completedSecondaries.addAll(mainLocations.subList(1, mainLocations.size()));
114112
}
115113
completedSecondaries.addAll(secondaries);
116114

0 commit comments

Comments
 (0)