Skip to content

incremental_orbitfit fails unless the id column is named provID #515

Description

@matthewholman

_observations_for_update does not take primary_id_column_name and reads
d["provID"] directly (orbitfit.py:1735 and :1747), so the sequential-update
path only works when the id column happens to have the default name:

incremental_orbitfit(data, cache_dir, prior, primary_id_column_name="ObjID")
# ValueError: no field of name provID

via sequential_update -> _observations_for_update. orbitfit() handles
ObjID fine, so only the incremental path is affected. The existing incremental
tests all use provID, which is why it does not show up.

Fix is to thread the column name through and use it.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingorbitfittasks that need to be completed as part of layup orbfit

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions