Don't set the relationshipLinks when it returns null

Author: VincentMolinie

lib/serializer-utils.js

@@ -154,8 +154,10 @@ module.exports = function (collectionName, record, payload, opts) {
       }
 
       if (opts.relationshipLinks) {
-        dest.relationships[keyForAttribute(attribute)].links =
-          getLinks(current[attribute], opts.relationshipLinks, dest);
+        const links = getLinks(current[attribute], opts.relationshipLinks, dest);
+        if (links.related) {
+          dest.relationships[keyForAttribute(attribute)].links = links;
+        }
       }
 
       if (opts.relationshipMeta) {

test/serializer.js

@@ -2559,5 +2559,29 @@ describe('JSON API Serializer', function () {
         relationships: { publisher: { data: null, links: { related: 'bar' } } }
       }]);
     });
+
+    it('should not be set when the relationshipLinks return null', function () {
+      var dataSet = {
+        id: '54735750e16638ba1eee59cb',
+        firstName: 'Sandro',
+        lastName: 'Munda',
+        address: null,
+      };
+
+      var json = new JSONAPISerializer('users', {
+        attributes: ['firstName', 'lastName', 'address'],
+        address: {
+          ref: 'id',
+          included: false,
+          relationshipLinks: {
+            related: function () {
+              return null;
+            }
+          },
+        }
+      }).serialize(dataSet);
+
+      expect(json.data.relationships.address).eql({ data: null });
+    });
   });
 });