Skip to content

[BUG] Set $mailchimpState field as nullable #91

Description

@lamasfoker

I think that \Setono\SyliusMailchimpPlugin\Model\MailchimpAwareTrait::$mailchimpState should be nullable and defined as below:

    /**
     * @var string
     *
     * @ORM\Column(type="string", nullable=true)
     */
    protected $mailchimpState = self::MAILCHIMP_STATE_PENDING;

In this way, this field of the entities (order and customer) already present on the DB will be null.
It has to be null and not an empty string as is right now and I have explained the reason here.

getMailchimpState() and setMailchimpState() should be changed accordingly.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions