From 40d816aa824e4f69e010e44ba07511eafb4089f9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Joachim=20L=C3=B8vgaard?= <joachim@loevgaard.dk>
Date: Mon, 7 Sep 2026 13:58:26 +0200
Subject: [PATCH] Housekeeping: drop the stale cache, fail on deprecations

Remove the .phpunit.result.cache entry and the file it referred to, left
at the root from before cacheDirectory was configured, and turn on
failOnDeprecation with restrictDeprecations so this bundle's own
deprecations surface without the upstream ones from
setono/bot-detection-bundle masking them.

Fixes #33
---
 .gitignore       |  1 -
 phpunit.xml.dist | 15 +++++++++++++--
 2 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/.gitignore b/.gitignore
index f99cb76..c2081e8 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,4 +1,3 @@
 /vendor/
 /composer.lock
-/.phpunit.result.cache
 /.build/
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
index 3332a2c..bf9da57 100644
--- a/phpunit.xml.dist
+++ b/phpunit.xml.dist
@@ -1,7 +1,8 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
          xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd" bootstrap="vendor/autoload.php"
-         colors="true" cacheDirectory=".build/phpunit">
+         colors="true" cacheDirectory=".build/phpunit"
+         failOnDeprecation="true" failOnNotice="true" failOnWarning="true">
     <testsuites>
         <testsuite name="unit">
             <directory>tests/Unit</directory>
@@ -10,7 +11,17 @@
             <directory>tests/Integration</directory>
         </testsuite>
     </testsuites>
-    <source>
+
+    <!--
+        restrictDeprecations keeps the report to deprecations this bundle's own code triggers, so an upstream one
+        does not drown ours out and failOnDeprecation can stay on. setono/bot-detection-bundle currently has
+        implicitly nullable parameters, which PHP 8.4 deprecates and PHP 9 will reject.
+
+        Do NOT let PHPUnit migrate this file: the migration renames the attribute to ignoreIndirectDeprecations,
+        which PHPUnit 10.5 rejects. We still need 10.5, because PHPUnit 11 requires PHP 8.2 and this bundle
+        supports 8.1
+    -->
+    <source restrictNotices="true" restrictWarnings="true" restrictDeprecations="true">
         <include>
             <directory suffix=".php">src/</directory>
         </include>