You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
.idea/ exists locally but is not in .gitignore; it is untracked only because nobody added it yet. Add /.idea/ or rely on a global gitignore and say so in a contributing note.
A stale .phpunit.result.cache sits at the repository root while phpunit.xml.dist sets cacheDirectory=".build/phpunit". It is gitignored; delete it and drop the ignore entry.
Running the suite on PHP 8.4 reports three deprecations, all from setono/bot-detection-bundle (BotDetector::__construct() parameter $popular and BotDetectorInterface::isBotRequest() parameter $request are implicitly nullable). These become errors in PHP 9. Fix upstream with explicit ?Type and bump the constraint here. Until then consider a PHPUnit deprecation policy (failOnDeprecation with a baseline, or SYMFONY_DEPRECATIONS_HELPER) so new deprecations from this bundle's own code are not hidden in the noise.
Small items collected from the review:
.idea/exists locally but is not in.gitignore; it is untracked only because nobody added it yet. Add/.idea/or rely on a global gitignore and say so in a contributing note..phpunit.result.cachesits at the repository root whilephpunit.xml.distsetscacheDirectory=".build/phpunit". It is gitignored; delete it and drop the ignore entry.setono/bot-detection-bundle(BotDetector::__construct()parameter$popularandBotDetectorInterface::isBotRequest()parameter$requestare implicitly nullable). These become errors in PHP 9. Fix upstream with explicit?Typeand bump the constraint here. Until then consider a PHPUnit deprecation policy (failOnDeprecationwith a baseline, orSYMFONY_DEPRECATIONS_HELPER) so new deprecations from this bundle's own code are not hidden in the noise.codecov/codecov-actionruns with a token but nothing consumes the result; either add a Codecov status check or drop the upload (see Test coverage: 46% of lines, 2 of 29 classes fully covered, no end-to-end test #32).