Used module level variable for observer

euangoddard · euangoddard · commit 9b49d4935230 · 2019-06-24T08:46:14.000+01:00
Post-review changes
diff --git a/src/definitions/modules/modal.js b/src/definitions/modules/modal.js
@@ -138,7 +138,7 @@ $.fn.modal = function(parameters) {
         },
 
         destroy: function() {
-          if (module.observer) {
+          if (observer) {
             observer.disconnect();
           }
           module.verbose('Destroying previous modal');
@@ -163,7 +163,6 @@ $.fn.modal = function(parameters) {
               subtree   : true
             });
             module.debug('Setting up mutation observer', observer);
-            module.observer = observer;
           }
         },
 

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ $.fn.modal = function(parameters) {`
`138`	`138`	`},`
`139`	`139`
`140`	`140`	`destroy: function() {`
`141`		`- if (module.observer) {`
	`141`	`+ if (observer) {`
`142`	`142`	`observer.disconnect();`
`143`	`143`	`}`
`144`	`144`	`module.verbose('Destroying previous modal');`
`@@ -163,7 +163,6 @@ $.fn.modal = function(parameters) {`
`163`	`163`	`subtree : true`
`164`	`164`	`});`
`165`	`165`	`module.debug('Setting up mutation observer', observer);`
`166`		`- module.observer = observer;`
`167`	`166`	`}`
`168`	`167`	`},`
`169`	`168`