From 8414a9fc4b7e089422aabb09cc6c988bf77b164a Mon Sep 17 00:00:00 2001 From: Nico Miguelino Date: Thu, 3 Sep 2026 20:15:04 -0700 Subject: [PATCH] Use EDGE_APP_ID for stage and production deploys (#12) - Set STAGE_EDGE_APP_ID and PRODUCTION_EDGE_APP_ID repo variables and pass them through to the initialize/update actions as edge_app_id - Drop id from screenly.yml and delete screenly_qc.yml since a single manifest is now used regardless of environment - Pin edge-apps-actions to a commit for now, since v26.9.0 can't be tagged there until a repo ruleset is adjusted --- .github/workflows/initialize-edge-app.yml | 3 +- .github/workflows/update-edge-app.yml | 6 +- screenly.yml | 1 - screenly_qc.yml | 270 ---------------------- 4 files changed, 6 insertions(+), 274 deletions(-) delete mode 100644 screenly_qc.yml diff --git a/.github/workflows/initialize-edge-app.yml b/.github/workflows/initialize-edge-app.yml index 9f69574..057dee0 100644 --- a/.github/workflows/initialize-edge-app.yml +++ b/.github/workflows/initialize-edge-app.yml @@ -31,9 +31,10 @@ jobs: - uses: actions/checkout@v7 with: ref: ${{ inputs.environment == 'production' && 'main' || github.ref }} - - uses: Screenly/edge-apps-actions/initialize@v1 + - uses: Screenly/edge-apps-actions/initialize@f4ccd2bd50db5fb0a5147d287ac03cafe552d29b with: screenly_api_token: ${{ secrets.SCREENLY_API_TOKEN }} edge_app_name: ${{ inputs.edge_app_name }} edge_app_title: ${{ inputs.edge_app_title }} environment: ${{ inputs.environment }} + edge_app_id: ${{ secrets.EDGE_APP_ID || (inputs.environment == 'production' && vars.PRODUCTION_EDGE_APP_ID || (inputs.environment == 'stage' && vars.STAGE_EDGE_APP_ID)) }} diff --git a/.github/workflows/update-edge-app.yml b/.github/workflows/update-edge-app.yml index 41887ea..65c4b79 100644 --- a/.github/workflows/update-edge-app.yml +++ b/.github/workflows/update-edge-app.yml @@ -17,11 +17,12 @@ jobs: environment: stage steps: - uses: actions/checkout@v7 - - uses: Screenly/edge-apps-actions/update@v1 + - uses: Screenly/edge-apps-actions/update@f4ccd2bd50db5fb0a5147d287ac03cafe552d29b with: screenly_api_token: ${{ secrets.SCREENLY_API_TOKEN }} environment: stage delete_missing_settings: 'true' + edge_app_id: ${{ secrets.EDGE_APP_ID || vars.STAGE_EDGE_APP_ID }} deploy-production: name: Updating TradingView Widget in production @@ -30,8 +31,9 @@ jobs: environment: production steps: - uses: actions/checkout@v7 - - uses: Screenly/edge-apps-actions/update@v1 + - uses: Screenly/edge-apps-actions/update@f4ccd2bd50db5fb0a5147d287ac03cafe552d29b with: screenly_api_token: ${{ secrets.SCREENLY_API_TOKEN }} environment: production delete_missing_settings: 'true' + edge_app_id: ${{ secrets.EDGE_APP_ID || vars.PRODUCTION_EDGE_APP_ID }} diff --git a/screenly.yml b/screenly.yml index 1c87a52..2814852 100644 --- a/screenly.yml +++ b/screenly.yml @@ -1,6 +1,5 @@ --- syntax: manifest_v1 -id: 01KZPBC3T88P2YJNRDW9BHWKCJ description: Full-screen TradingView market widgets (Advanced Chart, Symbol Overview, Stock Heatmap, Crypto Heatmap) icon: https://playground.srly.io/edge-apps/icons/tradingview.svg author: Screenly, Inc. diff --git a/screenly_qc.yml b/screenly_qc.yml deleted file mode 100644 index 77457a2..0000000 --- a/screenly_qc.yml +++ /dev/null @@ -1,270 +0,0 @@ ---- -syntax: manifest_v1 -id: 01KXP94BN058XWHFKVQJVH9PKP -description: Full-screen TradingView market widgets (Advanced Chart, Symbol Overview, Stock Heatmap, Crypto Heatmap) -icon: https://playground.srly.io/edge-apps/icons/tradingview.svg -author: Screenly, Inc. -categories: - - Finance -ready_signal: true -settings: - allow_symbol_change: - type: string - default_value: 'false' - title: Allow Symbol Change - optional: true - help_text: - properties: - advanced: true - depends_on: - setting: widget_type - values: - - advanced_chart - display_order: 6 - help_text: Let viewers change the symbol on the chart. Usually left off for unattended signage. - type: boolean - schema_version: 1 - chart_style: - type: string - default_value: '1' - title: Chart Style - optional: true - help_text: - properties: - advanced: true - depends_on: - setting: widget_type - values: - - advanced_chart - display_order: 2 - help_text: Candle/bar/line style for the chart. - options: - - label: Candles - value: '1' - - label: Bars - value: '0' - - label: Line - value: '2' - - label: Area - value: '3' - type: select - schema_version: 1 - display_errors: - type: string - default_value: 'false' - title: Display Errors - optional: true - help_text: - properties: - advanced: true - display_order: 8 - help_text: For debugging purposes, display errors on the screen instead of failing silently. - type: boolean - schema_version: 1 - heatmap_dataset: - type: string - default_value: SPX500 - title: Heatmap Dataset - optional: true - help_text: - properties: - depends_on: - setting: widget_type - values: - - stock_heatmap - display_order: 3 - help_text: Which market the Stock Heatmap visualizes. - options: - - label: S&P 500 (US) - value: SPX500 - - label: Nasdaq 100 (US) - value: NASDAQ100 - - label: Dow Jones Industrial Average (US) - value: DJDJI - - label: All US Stocks - value: AllUSA - - label: FTSE 100 (UK) - value: UK100 - - label: DAX (Germany) - value: DAX - - label: Nikkei 225 (Japan) - value: NI225 - - label: Shenzhen Component (China) - value: SZSE399001 - - label: Nifty 50 (India) - value: NIFTY50 - - label: TSX (Canada) - value: TSX - - label: ASX 200 (Australia) - value: ASX200 - - label: Ibovespa (Brazil) - value: IBOV - type: select - schema_version: 1 - heatmap_grouping: - type: string - default_value: sector - title: Heatmap Grouping - optional: true - help_text: - properties: - advanced: true - depends_on: - setting: widget_type - values: - - stock_heatmap - display_order: 7 - help_text: Group the Stock Heatmap's blocks by sector, or show a flat grid. - options: - - label: By Sector - value: sector - - label: No Grouping - value: no_group - type: select - schema_version: 1 - hide_legend: - type: string - default_value: 'false' - title: Hide Legend - optional: true - help_text: - properties: - advanced: true - depends_on: - setting: widget_type - values: - - advanced_chart - display_order: 5 - help_text: Hide the chart's symbol legend overlay. - type: boolean - schema_version: 1 - hide_side_toolbar: - type: string - default_value: 'true' - title: Hide Side Toolbar - optional: true - help_text: - properties: - advanced: true - depends_on: - setting: widget_type - values: - - advanced_chart - display_order: 4 - help_text: Hide the chart's left-hand drawing toolbar. - type: boolean - schema_version: 1 - hide_top_toolbar: - type: string - default_value: 'false' - title: Hide Top Toolbar - optional: true - help_text: - properties: - advanced: true - depends_on: - setting: widget_type - values: - - advanced_chart - display_order: 3 - help_text: Hide the chart's top toolbar (interval/style controls). - type: boolean - schema_version: 1 - interval: - type: string - default_value: D - title: Chart Interval - optional: true - help_text: - properties: - advanced: true - depends_on: - setting: widget_type - values: - - advanced_chart - display_order: 1 - help_text: Default time interval for the chart. - options: - - label: 1 minute - value: '1' - - label: 5 minutes - value: '5' - - label: 15 minutes - value: '15' - - label: 30 minutes - value: '30' - - label: 1 hour - value: '60' - - label: 4 hours - value: '240' - - label: 1 day - value: D - - label: 1 week - value: W - - label: 1 month - value: M - type: select - schema_version: 1 - locale: - type: string - default_value: en - title: Locale - optional: true - help_text: - properties: - display_order: 5 - help_text: Language code for the widget UI (e.g. en, fr, de, ja). - type: string - schema_version: 1 - symbol: - type: string - default_value: NASDAQ:AAPL - title: Symbol - optional: true - help_text: - properties: - depends_on: - setting: widget_type - values: - - advanced_chart - - symbol_overview - display_order: 2 - help_text: The ticker to display, in EXCHANGE:SYMBOL format (e.g. NASDAQ:AAPL, BINANCE:BTCUSDT). Symbol Overview intentionally shows a single symbol only, since its multi-symbol tab switcher requires mouse input unattended signage can't provide. - type: string - schema_version: 1 - theme: - type: string - default_value: dark - title: Color Theme - optional: true - help_text: - properties: - display_order: 4 - help_text: Dark or light mode for the widget. - options: - - label: Dark - value: dark - - label: Light - value: light - type: select - schema_version: 1 - widget_type: - type: string - default_value: advanced_chart - title: Widget Type - optional: true - help_text: - properties: - display_order: 1 - help_text: Which TradingView widget to display full-screen. The settings below change to match. - options: - - label: Advanced Real-Time Chart - value: advanced_chart - - label: Symbol Overview - value: symbol_overview - - label: Stock Heatmap - value: stock_heatmap - - label: Crypto Heatmap - value: crypto_heatmap - type: select - schema_version: 1