Skip to content

Commit 8b45e3f

Browse files
committed
Updated is_representative docstring, and changed the physical table mapping to use the deployability index.
Signed-off-by: davem-bis <68955845+davem-bis@users.noreply.github.com>
1 parent 97bfc28 commit 8b45e3f

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

‎sqlmesh/core/snapshot/definition.py‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1609,14 +1609,14 @@ def is_deployable(self, snapshot: SnapshotIdLike) -> bool:
16091609
)
16101610

16111611
def is_representative(self, snapshot: SnapshotIdLike) -> bool:
1612-
"""Returns true if the deployable (non-dev) table of the given snapshot should be used for reading, table mapping, and
1613-
computing missing intervals.
1612+
"""Returns true if the deployable (non-dev) table of the given snapshot should be used for reading.
16141613
16151614
Note, that deployable snapshots are also representative, but the reverse is not always true.
16161615
16171616
Unlike `is_deployable`, this variant also captures FORWARD_ONLY and INDIRECT_NON_BREAKING snapshots that
1618-
are not deployable by their nature but are currently promoted in production. Therefore, it's safe to consider
1619-
them as such when constructing a plan, building a physical table mapping or computing missing intervals.
1617+
are not deployable by their nature but are currently promoted in production. This is used when constructing
1618+
a plan to determine prod promotion staging (e.g. which snapshots backfill before promote) and whether a
1619+
physical table needs to be created.
16201620
16211621
Args:
16221622
snapshot: The snapshot to check.
@@ -1997,7 +1997,7 @@ def to_table_mapping(
19971997
) -> t.Dict[str, str]:
19981998
deployability_index = deployability_index or DeployabilityIndex.all_deployable()
19991999
return {
2000-
snapshot.name: snapshot.table_name(deployability_index.is_representative(snapshot))
2000+
snapshot.name: snapshot.table_name(deployability_index.is_deployable(snapshot))
20012001
for snapshot in snapshots
20022002
if snapshot.version and not snapshot.is_embedded and snapshot.is_model
20032003
}

0 commit comments

Comments
 (0)