Repository navigation
Commit 735b26f
committed
fix(audits): fail at_least_one when no row has a non-NULL value
The at_least_one audit grouped by the constant 1, so an empty table, or
a condition that filters out every row, produced no groups at all and
the audit passed even though no row has a non-NULL value in the column.
Aggregate over the whole table instead and keep the HAVING check, which
returns a single row whenever the non-NULL count is zero.
Signed-off-by: Dhruv Gupta <todhruvg@gmail.com>1 parent f0ed98e commit 735b26f
2 files changed
Lines changed: 37 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
137 | 137 | | |
138 | 138 | | |
139 | 139 | | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
140 | 143 | | |
141 | 144 | | |
142 | 145 | | |
143 | 146 | | |
144 | | - | |
| 147 | + | |
145 | 148 | | |
146 | 149 | | |
147 | | - | |
148 | 150 | | |
149 | 151 | | |
150 | 152 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
| 3 | + | |
2 | 4 | | |
3 | 5 | | |
4 | 6 | | |
| |||
712 | 714 | | |
713 | 715 | | |
714 | 716 | | |
715 | | - | |
| 717 | + | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
| 721 | + | |
| 722 | + | |
| 723 | + | |
| 724 | + | |
| 725 | + | |
716 | 726 | | |
| 727 | + | |
| 728 | + | |
| 729 | + | |
| 730 | + | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
| 735 | + | |
| 736 | + | |
| 737 | + | |
| 738 | + | |
| 739 | + | |
| 740 | + | |
| 741 | + | |
| 742 | + | |
| 743 | + | |
| 744 | + | |
| 745 | + | |
| 746 | + | |
| 747 | + | |
| 748 | + | |
717 | 749 | | |
718 | 750 | | |
719 | 751 | | |
| |||
0 commit comments