|
5 | 5 | import pytest |
6 | 6 | from pytest_mock.plugin import MockerFixture |
7 | 7 | from sqlglot import exp, parse_one |
| 8 | +from sqlglot.errors import ParseError |
8 | 9 | from sqlglot.optimizer.normalize_identifiers import normalize_identifiers |
9 | 10 |
|
10 | 11 | import sqlmesh.core.dialect as d |
@@ -1804,3 +1805,71 @@ def test_clustering_key_issue_5813_clone_inherited_column_drop( |
1804 | 1805 | ] |
1805 | 1806 | for kept in ('"TENANT_ID"', '"USER_ID"', '"SESSION_START_TS"'): |
1806 | 1807 | assert not any(f"DROP COLUMN {kept}" in sql for sql in sql_calls) |
| 1808 | + |
| 1809 | + |
| 1810 | +def test_clustering_key_unparseable_without_column_drop_skips_parse( |
| 1811 | + make_mocked_engine_adapter: t.Callable, mocker: MockerFixture |
| 1812 | +) -> None: |
| 1813 | + """A key string that cannot be parsed is ignored unless a column is dropped. |
| 1814 | +
|
| 1815 | + LINEAR( is not valid Snowflake SQL. With no column drop, the current key is not |
| 1816 | + parsed: an unchanged key emits nothing, and a removed or replaced key is appended. |
| 1817 | + """ |
| 1818 | + unchanged = _make_snowflake_clustering_adapter( |
| 1819 | + make_mocked_engine_adapter, |
| 1820 | + mocker, |
| 1821 | + current_columns={"ID": "INT"}, |
| 1822 | + target_columns={"ID": "INT"}, |
| 1823 | + current_clustering_key="LINEAR(", |
| 1824 | + target_clustering_key="LINEAR(", |
| 1825 | + ) |
| 1826 | + assert ( |
| 1827 | + unchanged.get_alter_operations("catalog.db.current_table", "catalog.db.target_table") == [] |
| 1828 | + ) |
| 1829 | + |
| 1830 | + removed = _make_snowflake_clustering_adapter( |
| 1831 | + make_mocked_engine_adapter, |
| 1832 | + mocker, |
| 1833 | + current_columns={"ID": "INT"}, |
| 1834 | + target_columns={"ID": "INT"}, |
| 1835 | + current_clustering_key="LINEAR(", |
| 1836 | + target_clustering_key=None, |
| 1837 | + ) |
| 1838 | + removed_operations = removed.get_alter_operations( |
| 1839 | + "catalog.db.current_table", "catalog.db.target_table" |
| 1840 | + ) |
| 1841 | + removed.alter_table(removed_operations) |
| 1842 | + assert [type(op) for op in removed_operations] == [TableAlterDropClusterKeyOperation] |
| 1843 | + assert to_sql_calls(removed) == [_cluster_alter("DROP CLUSTERING KEY")] |
| 1844 | + |
| 1845 | + replaced = _make_snowflake_clustering_adapter( |
| 1846 | + make_mocked_engine_adapter, |
| 1847 | + mocker, |
| 1848 | + current_columns={"ID": "INT"}, |
| 1849 | + target_columns={"ID": "INT"}, |
| 1850 | + current_clustering_key="LINEAR(", |
| 1851 | + target_clustering_key='LINEAR("ID")', |
| 1852 | + ) |
| 1853 | + replaced_operations = replaced.get_alter_operations( |
| 1854 | + "catalog.db.current_table", "catalog.db.target_table" |
| 1855 | + ) |
| 1856 | + replaced.alter_table(replaced_operations) |
| 1857 | + assert [type(op) for op in replaced_operations] == [TableAlterChangeClusterKeyOperation] |
| 1858 | + assert to_sql_calls(replaced) == [_cluster_alter('CLUSTER BY ("ID")')] |
| 1859 | + |
| 1860 | + |
| 1861 | +def test_clustering_key_unparseable_column_drop_still_raises( |
| 1862 | + make_mocked_engine_adapter: t.Callable, mocker: MockerFixture |
| 1863 | +) -> None: |
| 1864 | + """Dropping a column still parses the current key, so a bad key still fails.""" |
| 1865 | + adapter = _make_snowflake_clustering_adapter( |
| 1866 | + make_mocked_engine_adapter, |
| 1867 | + mocker, |
| 1868 | + current_columns={"ID": "INT", "EXTRA": "INT"}, |
| 1869 | + target_columns={"ID": "INT"}, |
| 1870 | + current_clustering_key="LINEAR(", |
| 1871 | + target_clustering_key=None, |
| 1872 | + ) |
| 1873 | + |
| 1874 | + with pytest.raises(ParseError): |
| 1875 | + adapter.get_alter_operations("catalog.db.current_table", "catalog.db.target_table") |
0 commit comments