Skip to content

Commit 1952387

Browse files
committed
Fix Redshift parenthesized single-column SORTKEY
Signed-off-by: Simen Strand <simen.strand@netcheck.de>
1 parent 1bef6a8 commit 1952387

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

‎sqlmesh/core/engine_adapter/redshift.py‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,12 @@ def _to_identifier_if_string(expression: exp.Expr) -> exp.Expr:
295295

296296
sortkey = table_properties.get("SORTKEY")
297297
if sortkey:
298-
sortkey_expressions = sortkey.expressions if sortkey.expressions else [sortkey]
298+
if isinstance(sortkey, (exp.Tuple, exp.Array)):
299+
sortkey_expressions = sortkey.expressions
300+
elif isinstance(sortkey, exp.Paren):
301+
sortkey_expressions = [sortkey.unnest()]
302+
else:
303+
sortkey_expressions = [sortkey]
299304
properties.append(
300305
exp.SortKeyProperty(
301306
this=[

‎tests/core/engine_adapter/test_redshift.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ def test_create_table_physical_properties_from_model_definition(
167167
physical_properties (
168168
diststyle = key,
169169
distkey = "id_file",
170-
sortkey = "batch_time"
170+
sortkey = ("batch_time")
171171
)
172172
);
173173
SELECT id_file::INT, batch_time::TIMESTAMP;

0 commit comments

Comments
 (0)