Skip to content

fix: [DevOps] Japicmp use orchestration-staging as baseline #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rpanackal wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −7
Open

fix: [DevOps] Japicmp use orchestration-staging as baseline #894

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions .github/workflows/spec-update.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,15 +233,16 @@ jobs:
if: steps.spec_diff.outputs.spec_diff == 'true'
env:
MODULE_PATH: ${{ steps.download.outputs.module_path }}
BASE: ${{ steps.pr_base.outputs.BASE }}
run: |
# Extract main branch source into a temporary directory
git fetch --no-tags --depth=1 origin main
mkdir -p /tmp/main-baseline
git archive origin/main | tar -x -C /tmp/main-baseline
# Extract $BASE branch source into a temporary directory
git fetch --no-tags --depth=1 origin "$BASE"
mkdir -p /tmp/api-baseline
git archive "origin/$BASE" | tar -x -C /tmp/api-baseline

# Build inside a subshell to avoid polluting the working directory
(
cd /tmp/main-baseline
cd /tmp/api-baseline
mvn package -DskipTests -pl "$MODULE_PATH" -am ${{ env.MVN_MULTI_THREADED_ARGS }}
FINAL_NAME=$(mvn -q -pl "$MODULE_PATH" help:evaluate -Dexpression=project.build.finalName -DforceStdout)
cp "$MODULE_PATH/target/${FINAL_NAME}.jar" /tmp/baseline.jar
Expand Down Expand Up @@ -270,9 +271,9 @@ jobs:
FINAL_NAME=$(mvn -q -pl "$MODULE_PATH" help:evaluate -Dexpression=project.build.finalName -DforceStdout)
CURRENT_JAR="$MODULE_PATH/target/${FINAL_NAME}.jar"

# Run japicmp: compare baseline (main) JAR vs newly generated JAR
# Run japicmp: compare baseline ($BASE) JAR vs newly generated JAR
if mvn com.github.siom79.japicmp:japicmp-maven-plugin:cmp@api-compatibility \
-pl "$MODULE_PATH" \
-pl "$MODULE_PATH" \
-Djapicmp.oldVersion.file=/tmp/baseline.jar \
-Djapicmp.newVersion.file="$CURRENT_JAR" \
${{ env.MVN_MULTI_THREADED_ARGS }} ; then
Expand Down