fix: [DevOps] Japicmp use orchestration-staging as baseline#894
Open
rpanackal wants to merge 1 commit into
Open
fix: [DevOps] Japicmp use orchestration-staging as baseline#894rpanackal wants to merge 1 commit into
rpanackal wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
AI/ai-sdk-java-backlog#ISSUENUMBER.
Changing the narative of the Japicmp check from
towards
orchestration-stagingbranch contains fixes that are human-reviewed and accepted.Without this change, orchestration PRs that already has a fix ready will keep failing since the defacto baseline is main. This is just noisy since some team member already looked at the problem, fixed it and created
orchestration-staging. Without this, every upcoming orchestration PRs will always fail too.Feature scope:
Definition of Done
Error handling created / updated & covered by the tests aboveAligned changes with the JavaScript SDKDocumentation updatedRelease notes updated