Skip to content

Commit ac78517

Browse files
authored
Skip TestScander.test_uninstantiable (RustPython#5204)
This test was marked as an expected failure. Because the garbage collector is missing, that meant that the `os.scandir` object went unclosed. This object was squatting on the file descriptors of all the files contained in the test directory, which was breaking test_zipfile.
1 parent 426e582 commit ac78517

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

‎Lib/test/test_os.py‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4249,7 +4249,8 @@ def assert_stat_equal(self, stat1, stat2, skip_fields):
42494249
self.assertEqual(stat1, stat2)
42504250

42514251
# TODO: RUSTPPYTHON (AssertionError: TypeError not raised by ScandirIter)
4252-
@unittest.expectedFailure
4252+
# TODO: See https://github.com/RustPython/RustPython/issues/5190 for skip rationale
4253+
@unittest.skip("skipping to avoid the unclosed scandir from squatting on file descriptors")
42534254
def test_uninstantiable(self):
42544255
scandir_iter = os.scandir(self.path)
42554256
self.assertRaises(TypeError, type(scandir_iter))

0 commit comments

Comments
 (0)