Skip to content

Commit 61feb43

Browse files
hydrogen602youknowone
authored andcommitted
test_builtin.py: test_type_qualname fix
1 parent 07fdcb6 commit 61feb43

2 files changed

Lines changed: 9 additions & 2 deletions

File tree

‎Lib/test/test_builtin.py‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2441,8 +2441,6 @@ def test_type_name(self):
24412441
A.__name__ = b'A'
24422442
self.assertEqual(A.__name__, 'C')
24432443

2444-
# TODO: RUSTPYTHON
2445-
@unittest.expectedFailure
24462444
def test_type_qualname(self):
24472445
A = type('A', (), {'__qualname__': 'B.C'})
24482446
self.assertEqual(A.__name__, 'A')

‎vm/src/builtins/type.rs‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,15 @@ impl PyType {
206206
slots.flags |= PyTypeFlags::HAS_DICT
207207
}
208208

209+
if let Some(qualname) = attrs.get(identifier!(ctx, __qualname__)) {
210+
if !qualname.fast_isinstance(ctx.types.str_type) {
211+
return Err(format!(
212+
"type __qualname__ must be a str, not {}",
213+
qualname.class().name()
214+
));
215+
}
216+
}
217+
209218
let new_type = PyRef::new_ref(
210219
PyType {
211220
base: Some(base),

0 commit comments

Comments
 (0)