Skip to content

Commit 4881f61

Browse files
committed
Mark env::{set,remove}_var() unsafe
1 parent ff9947f commit 4881f61

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

‎Cargo.toml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,7 @@ unsafe_code = "allow"
192192
unsafe_op_in_unsafe_fn = "deny"
193193
missing_unsafe_on_extern = "deny"
194194
unsafe_attr_outside_unsafe = "deny"
195+
deprecated_safe_2024 = "deny"
195196

196197
[workspace.lints.clippy]
197198
perf = "warn"

‎vm/src/stdlib/os.rs‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,8 @@ pub(super) mod _os {
401401
}
402402
let key = super::bytes_as_osstr(key, vm)?;
403403
let value = super::bytes_as_osstr(value, vm)?;
404-
env::set_var(key, value);
404+
// SAFETY: requirements forwarded from the caller
405+
unsafe { env::set_var(key, value) };
405406
Ok(())
406407
}
407408

@@ -421,7 +422,8 @@ pub(super) mod _os {
421422
));
422423
}
423424
let key = super::bytes_as_osstr(key, vm)?;
424-
env::remove_var(key);
425+
// SAFETY: requirements forwarded from the caller
426+
unsafe { env::remove_var(key) };
425427
Ok(())
426428
}
427429

0 commit comments

Comments
 (0)