Skip to content

fix(alsa): hanging double-opens with BufferSize::Fixed om some drivers #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roderickvd merged 5 commits into from
May 23, 2026
+388 −274
Merged

fix(alsa): hanging double-opens with BufferSize::Fixed om some drivers #1214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
454c322
fix(alsa): prevent double opens with BufferSize::Fixed
roderickvd May 20, 2026
b57e74f
feat(alsa): defend against hangs due to polling timeouts
roderickvd May 20, 2026
1504475
fix(alsa): enumeration and validation of buffers and sample rates
roderickvd May 21, 2026
d8a6f36
feat(alsa): enumerate up to 64 channels (AES10 maximum)
roderickvd May 23, 2026
d6fe895
fix(alsa): validate StreamConfig for zero channels, sample rate, and …
roderickvd May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- `BufferSize` now implements `Default` (returns `BufferSize::Default`).
- `SupportedBufferSize` now implements `Default` (returns `SupportedBufferSize::Unknown`).
- `SupportedStreamConfig` now implements `Copy`.
- DSD512 sample rates added to the common rate probe list.
- **AAudio**: Streams now request `PERFORMANCE_MODE_LOW_LATENCY` when the `realtime` feature is
enabled; stream error callback receives `ErrorKind::RealtimeDenied` if not granted.
- **AAudio**: `Device` now implements `PartialEq`, `Eq`, `Hash`, and `Debug`.
Expand Down Expand Up @@ -87,6 +88,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- **ALSA**: Streams no longer start automatically on creation; call `play()` manually.
- **ALSA**: The `realtime` feature now skips RT promotion for ineligible PCM types (null,
I/O plugins, wrapper types); `audio_thread_priority` promoted unconditionally.
- **ALSA**: Supported configurations are now enumerated up to 64 channels (AES10 maximum).
- **ASIO**: `Device::driver`, `asio_streams`, and `current_callback_flag` are no longer `pub`.
- **ASIO**: Timestamps now include driver-reported hardware latency.
- **ASIO**: Hardware latency is now re-queried when the driver reports `kAsioLatenciesChanged`.
Expand Down Expand Up @@ -169,6 +171,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- **ALSA**: Fix silence template not being applied for DSD.
- **ALSA**: Fix stream corruption on certain drivers with spurious wakeups.
- **ALSA**: Fix callbacks firing before `build_*_stream` returns the `Stream` handle.
- **ALSA**: Fix `BufferSize::Fixed` validation opening the PCM device a second time.
- **ALSA**: Fix hang when device raced to an error state without delivering POLLERR.
- **ALSA**: Fix `supported_configs()` reporting buffer size instead of period size.
- **ALSA**: Fix `supported_configs()` using the same buffer range for all formats and channels.
- **ALSA**: Fix `supported_configs()` dropping sample rates outside of `COMMON_SAMPLE_RATES`.
- **ALSA**: Fix `BufferSize::Fixed(0)` being silently accepted.
- **ASIO**: Fix enumeration returning only the first device when using `collect()`.
- **ASIO**: Fix device enumeration and stream creation failing when called from spawned threads.
- **ASIO**: Fix buffer size not resizing when the driver reports `kAsioBufferSizeChange`.
Expand Down
Loading
Loading