Commit 3c7422e
committed
fix(EditRoomInfo): align system-messages MultiSelect with new fuselage a11y
The MultiSelect anchor in @rocket.chat/fuselage now exposes role="combobox"
and uses aria-label/aria-labelledby for its accessible name (the placeholder
is rendered as inert children). The recently added EditRoomInfo.spec.tsx was
written against the previous fuselage where the anchor was a plain button
named by its placeholder, so getByRole('button', { name: /Select messages
to hide/i }) no longer matches and CI's Unit Tests fail on develop.
- Pass aria-label to the MultiSelect so the combobox has an accessible name.
- Update the spec helper to query by the combobox role.1 parent aed3c5d commit 3c7422e
3 files changed
Lines changed: 7 additions & 1 deletion
File tree
- .changeset
- apps/meteor/client/views/room/contextualBar/Info/EditRoomInfo
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | | - | |
| 67 | + | |
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
483 | 483 | | |
484 | 484 | | |
485 | 485 | | |
| 486 | + | |
486 | 487 | | |
487 | 488 | | |
488 | 489 | | |
| |||
0 commit comments