@@ -263,8 +263,8 @@ void Franka::controller_set_joint_position(const common::Vector7d& desired_q) {
263263 q = Eigen::Map<common::Vector7d>(this ->curr_state .q .data ());
264264 dq = Eigen::Map<common::Vector7d>(this ->curr_state .dq .data ());
265265 }
266- const double elapsed =
267- std::chrono::duration< double >( std::chrono::steady_clock::now () - start)
266+ const double elapsed = std::chrono::duration< double >(
267+ std::chrono::steady_clock::now () - start)
268268 .count ();
269269 const double pos_err = (q - desired_q).cwiseAbs ().maxCoeff ();
270270 const double vel = dq.cwiseAbs ().maxCoeff ();
@@ -338,11 +338,13 @@ void Franka::osc_set_cartesian_position(
338338 desired_pose_EE_in_base_frame.quaternion ().normalized ()));
339339 dot = std::min (1.0 , dot);
340340 const double rot_gap = 2.0 * std::acos (dot);
341- const double trans_speed = std::max (this ->m_cfg .approach_cartesian_speed , 1e-6 );
342- const double rot_speed = std::max (this ->m_cfg .approach_rotation_speed , 1e-6 );
343- approach_time = std::clamp (
344- std::max (trans_gap / trans_speed, rot_gap / rot_speed), kMinApproachTime ,
345- kMaxApproachTime );
341+ const double trans_speed =
342+ std::max (this ->m_cfg .approach_cartesian_speed , 1e-6 );
343+ const double rot_speed =
344+ std::max (this ->m_cfg .approach_rotation_speed , 1e-6 );
345+ approach_time =
346+ std::clamp (std::max (trans_gap / trans_speed, rot_gap / rot_speed),
347+ kMinApproachTime , kMaxApproachTime );
346348 }
347349
348350 this ->traj_interpolator .reset (
@@ -367,7 +369,8 @@ void Franka::osc_set_cartesian_position(
367369 const double vel_tol = 0.05 ; // rad/s (joint-space proxy for "stopped")
368370 const double timeout = approach_time + 2.0 ;
369371 const auto start = std::chrono::steady_clock::now ();
370- const Eigen::Vector3d target_p = desired_pose_EE_in_base_frame.translation ();
372+ const Eigen::Vector3d target_p =
373+ desired_pose_EE_in_base_frame.translation ();
371374 const Eigen::Quaterniond target_q =
372375 desired_pose_EE_in_base_frame.quaternion ().normalized ();
373376 while (true ) {
@@ -382,13 +385,12 @@ void Franka::osc_set_cartesian_position(
382385 const common::Pose meas_pose =
383386 GetTCPInBaseFrame (state, this ->m_cfg .tcp_offset );
384387 const double pos_err = (target_p - meas_pose.translation ()).norm ();
385- double dot =
386- std::abs (meas_pose.quaternion ().normalized ().dot (target_q));
388+ double dot = std::abs (meas_pose.quaternion ().normalized ().dot (target_q));
387389 dot = std::min (1.0 , dot);
388390 const double ori_err = 2.0 * std::acos (dot);
389391 const double vel = dq.cwiseAbs ().maxCoeff ();
390- const double elapsed =
391- std::chrono::duration< double >( std::chrono::steady_clock::now () - start)
392+ const double elapsed = std::chrono::duration< double >(
393+ std::chrono::steady_clock::now () - start)
392394 .count ();
393395 if (elapsed >= approach_time && pos_err < pos_tol && ori_err < ori_tol &&
394396 vel < vel_tol) {
0 commit comments