fixed an issue with other instances not being toggled to r/w, and ensured that the configuration goes back to Readonly correctly if you un toggle the rw

Author: RobThePCGuy

README.md

@@ -1,6 +1,10 @@
 # BlueStacks Root GUI
 
-This is an AIO application designed to simplify the configuration part of my original tutorial on how to [root BlueStacks](https://github.com/RobThePCGuy/Root-Bluestacks-with-Kitsune-Mask/) with Kitsune Mask. If you want to do things manually, then the original repo is where you go. This tool will allow you to toggle root access and read/write (R/W) modes for BlueStacks instances. It provides an intuitive interface for managing these settings without manually editing configuration files.
+>[!IMPORTANT]
+> This is an **unofficial modification**. It is not supported by the BlueStacks team, nor should you blame me or them if your dishwasher blows up. Work **IN** Progress only use if you are crazy!
+> As always, I am happy to accept help.
+
+This is an AIO application designed to simplify the configuration part of my original tutorial on how to [root BlueStacks](https://github.com/RobThePCGuy/Root-Bluestacks-with-Kitsune-Mask/) with Kitsune Mask. If you want to do things manually, then the original repo is where you go. This tool will allow you to toggle root access and read/write (R/W) modes for BlueStacks instances. It provides an intuitive interface for managing these settings without manually editing configuration files. It will not automatically download BlueStacks or Magisk, nor install either.. yet.
 
 ## Features
 
@@ -33,7 +37,8 @@ This is an AIO application designed to simplify the configuration part of my ori
    - **Toggle Root**: Toggles root access (`On`/`Off`) for the selected instance.
    - **Toggle R/W**: Toggles read/write mode (`On`/`Off`) for the selected instance.
 5. Observe the status updates (`Root: On/Off` and `R/W: On/Off`) next to each instance.
-6. Close the app when finished.
+6. Once you have installed Kitsune Mask and completed the direct install to the system partition part of my other tutorial, you can untoggle Root and leave the R/W checked. 
+7. Close the app when finished.
 
 ---
 
@@ -67,8 +72,8 @@ This is an AIO application designed to simplify the configuration part of my ori
 
 1. Clone the repository:
    ```bash
-   git clone https://github.com/your-repo-name.git
-   cd your-repo-name
+   git clone https://github.com/RobThePCGuy/BlueStacks-Root-GUI.git
+   cd BlueStacks-Root-GUI
    ```
 
 2. Install dependencies:
@@ -83,11 +88,11 @@ This is an AIO application designed to simplify the configuration part of my ori
 
 4. Build the `.exe` file:
    ```bash
-   pyinstaller --onefile --windowed main.py
+   pyinstaller --onefile --windowed --icon=main.ico main.py
    ```
 
 ---
 
 ## Contributions
 
-Contributions are welcome! Feel free to open an issue or submit a pull request.
+Contributions are welcome! Feel free to open an issue or submit a pull request.

instance_handler.py

@@ -1,15 +1,27 @@
-from docx import Document
 import os
+import glob  # Import the glob module
 
 def modify_instance_files(instance_path, file_names, new_type):
     """Modifies the type of specified files within an instance's .bstk files.
 
+    Directly replaces "Readonly" and "Normal" strings to toggle R/W status.
+
     Args:
         instance_path: The path to the instance directory (e.g., ...\Engine\Rvc64).
         file_names: A list of file names to modify (e.g., ["fastboot.vdi", "Root.vhd"]).
         new_type: The new type to set (e.g., "Normal" or "Readonly").
     """
-    for bstk_file_name in ["Android.bstk.in", f"{os.path.basename(instance_path)}.bstk"]:
+    bstk_files = ["Android.bstk.in"]
+
+    # Find the instance-specific .bstk file
+    instance_bstk_files = glob.glob(os.path.join(instance_path, "*.bstk"))
+    if instance_bstk_files:
+        bstk_files.append(os.path.basename(instance_bstk_files[0]))
+    else:
+        print(f"Error: No instance-specific .bstk file found in {instance_path}")
+        return
+
+    for bstk_file_name in bstk_files:
         bstk_file_path = os.path.join(instance_path, bstk_file_name)
 
         try:
@@ -19,9 +31,14 @@ def modify_instance_files(instance_path, file_names, new_type):
             modified = False
             with open(bstk_file_path, "w") as file:
                 for line in content:
-                    for file_name in file_names:
-                        if file_name in line:
-                            line = line.replace("Readonly", new_type).replace("Normal", new_type)
+                    # Check if any of the file_names are in the current line
+                    if any(file_name in line for file_name in file_names):
+                        # Replace "Readonly" or "Normal" with the new_type
+                        if "Readonly" in line:
+                            line = line.replace("Readonly", new_type)
+                            modified = True
+                        elif "Normal" in line:
+                            line = line.replace("Normal", new_type)
                             modified = True
                     file.write(line)
 
@@ -34,15 +51,15 @@ def modify_instance_files(instance_path, file_names, new_type):
             print(f"Error: Instance file not found at {bstk_file_path}")
         except Exception as e:
             print(f"Error modifying instance file: {e}")
-
+            
 def is_instance_readonly(instance_path):
     """Checks if the instance files are set to Readonly.
 
     Args:
         instance_path: The path to the instance directory.
 
     Returns:
-        True if the instance files are in Readonly mode, False otherwise.
+        True if any line in the instance files contains "Readonly", False otherwise.
     """
     for bstk_file_name in ["Android.bstk.in", f"{os.path.basename(instance_path)}.bstk"]:
         bstk_file_path = os.path.join(instance_path, bstk_file_name)
@@ -51,11 +68,11 @@ def is_instance_readonly(instance_path):
             with open(bstk_file_path, "r") as file:
                 for line in file:
                     if "Readonly" in line:
-                        return True
-            return False
+                        return True  # Found "Readonly" in a line
+            return False  # Did not find "Readonly" in any line
         except FileNotFoundError:
             print(f"Error: Instance file not found at {bstk_file_path}")
             return False
         except Exception as e:
             print(f"Error reading instance file: {e}")
-            return False
+            return False

main.py

@@ -102,10 +102,10 @@ def update_instance_data(self):
                 for line in f:
                     if line.startswith(INSTANCE_PREFIX) and ENABLE_ROOT_KEY in line:
                         instance_name = line.split(".")[2]
+                        instance_path = os.path.join(self.bluestacks_path, instance_name)
                         new_instance_data[instance_name] = {
                             "root_enabled": config_handler.is_root_enabled(self.config_path, instance_name),
-                            "rw_mode": "Normal" if not instance_handler.is_instance_readonly(
-                                os.path.join(self.bluestacks_path, instance_name)) else "Readonly"
+                            "rw_mode": "Normal" if not instance_handler.is_instance_readonly(instance_path) else "Readonly"
                         }
             self.instance_data = new_instance_data
         except Exception as e:
@@ -200,7 +200,7 @@ def toggle_root(self):
                     self.status_label.setText(f"Error toggling root for {instance_name}: {e}")
 
     def toggle_rw(self):
-        """Toggles R/W mode for selected instances."""
+        """Toggles R/W mode for selected instances, modifying both .bstk.in and .bstk files."""
         if not self.bluestacks_path:
             self.status_label.setText("Error: BlueStacks path not found.")
             return
@@ -214,6 +214,7 @@ def toggle_rw(self):
                     current_state = self.instance_data[instance_name]["rw_mode"]
                     new_state = "Normal" if current_state == "Readonly" else "Readonly"
 
+                    # Use the modify_instance_files from instance_handler
                     instance_handler.modify_instance_files(instance_path, [FASTBOOT_VDI, ROOT_VHD], new_state)
 
                     # Update the instance data and UI