fix: move UI sidecars to initContainers for RestartPolicy support#1783
Merged
Conversation
Container-level restartPolicy is only supported for init containers in K8s. Native sidecar pattern (K8s 1.29+) requires: - Init container with restartPolicy: Always - Starts concurrently with main container (not before) - Auto-terminates when main container exits Previous commit set restartPolicy: Always but left containers in spec.containers, where the field is ignored by the API server. This fix moves Selenium and Playwright containers to spec.initContainers where restartPolicy works. Fixes Job hang issue where UI sidecars prevented Job completion.
bsquizz
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Container-level restartPolicy is only supported for init containers in K8s. Native sidecar pattern (K8s 1.29+) requires:
Previous commit set restartPolicy: Always but left containers in spec.containers, where the field is ignored by the API server. This fix moves Selenium and Playwright containers to spec.initContainers where restartPolicy works.
Fixes Job hang issue where UI sidecars prevented Job completion.