Skip to content

Commit ac91984

Browse files
committed
fix tests
1 parent 911ee3e commit ac91984

33 files changed

Lines changed: 65 additions & 6 deletions

File tree

app/src/androidTest/java/com/example/util/simpletimetracker/StatisticsDetailExcludeTest.kt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,13 @@ import androidx.test.ext.junit.runners.AndroidJUnit4
1212
import com.example.util.simpletimetracker.core.mapper.ColorMapper
1313
import com.example.util.simpletimetracker.domain.statistics.model.ChartFilterType
1414
import com.example.util.simpletimetracker.feature_base_adapter.recordTypeSuggestion.RecordTypeSuggestionViewData
15+
import com.example.util.simpletimetracker.feature_change_record_type.R
16+
import com.example.util.simpletimetracker.feature_records_filter.viewData.CategoryFilteredType
1517
import com.example.util.simpletimetracker.feature_statistics_detail.adapter.StatisticsDetailBlock
1618
import com.example.util.simpletimetracker.utils.BaseUiTest
1719
import com.example.util.simpletimetracker.utils.Direction
1820
import com.example.util.simpletimetracker.utils.NavUtils
21+
import com.example.util.simpletimetracker.utils.NavUtils.fixToCurrentDate
1922
import com.example.util.simpletimetracker.utils.checkViewDoesNotExist
2023
import com.example.util.simpletimetracker.utils.clickOnView
2124
import com.example.util.simpletimetracker.utils.drag
@@ -210,6 +213,7 @@ class StatisticsDetailExcludeTest : BaseUiTest() {
210213
clickOnView(
211214
allOf(
212215
withId(baseR.id.viewCategoryItem),
216+
withTag(CategoryFilteredType),
213217
hasDescendant(withText(category2)),
214218
),
215219
)
@@ -331,6 +335,7 @@ class StatisticsDetailExcludeTest : BaseUiTest() {
331335
// Check default
332336
NavUtils.openFilter()
333337
Thread.sleep(1000)
338+
clickOnView(withSubstring(getString(R.string.records_filter_exclude)))
334339
clickOnView(
335340
allOf(
336341
isDescendantOfA(withId(baseR.id.viewCategoryItem)),
@@ -385,6 +390,7 @@ class StatisticsDetailExcludeTest : BaseUiTest() {
385390
private fun openStats() {
386391
NavUtils.openStatisticsScreen()
387392
tryAction { clickOnView(allOf(withText(R.string.statistics_total_tracked), isCompletelyDisplayed())) }
393+
fixToCurrentDate()
388394
}
389395

390396
private fun checkDefault() {

app/src/androidTest/java/com/example/util/simpletimetracker/utils/TestUtils.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@ import android.view.ViewGroup
55
import android.view.ViewParent
66
import com.google.android.material.appbar.AppBarLayout
77

8-
internal fun View.collapseAllAppBarsInParent() {
8+
internal fun View.changeAllAppBarsInParent(expanded: Boolean) {
99
findViewsInParent(AppBarLayout::class.java)
10-
.forEach { it.setExpanded(false) }
10+
.forEach { it.setExpanded(expanded) }
1111
}
1212

1313
internal fun <T> View.findViewsInParent(

app/src/androidTest/java/com/example/util/simpletimetracker/utils/ViewActions.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ fun collapseToolbar(): ViewAction = object : ViewAction {
222222
isDisplayed()
223223

224224
override fun perform(uiController: UiController?, view: View?) {
225-
view?.collapseAllAppBarsInParent()
225+
view?.changeAllAppBarsInParent(expanded = false)
226226
}
227227
}
228228

domain/src/main/java/com/example/util/simpletimetracker/domain/complexRule/interactor/ComplexRuleProcessActionInteractor.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,8 @@ class ComplexRuleProcessActionInteractor @Inject constructor(
4343
.filter { it.actionDisallowOnlyPrevious }
4444
.map { it.conditionCurrentTypeIds }
4545
.flatten().toSet()
46+
.takeUnless { rulesThatDisallow.any { !it.actionDisallowOnlyPrevious } }
47+
.orEmpty()
4648

4749
val additionalTags = assignTagRules.map { it.actionAssignTagIds }
4850
.flatten().toSet()

features/feature_base_adapter/src/main/java/com/example/util/simpletimetracker/feature_base_adapter/category/CategoryAdapterDelegate.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ fun createCategoryAdapterDelegate(
2222
with(binding.viewCategoryItem) {
2323
item as ViewData
2424

25+
tag = item.type
26+
2527
val transitionName = when (item) {
2628
is ViewData.Category -> TransitionNames.CATEGORY
2729
is ViewData.Record -> TransitionNames.RECORD_TAG

features/feature_complex_rules/src/main/java/com/example/util/simpletimetracker/feature_complex_rules/interactor/ComplexRulesViewDataInteractor.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ class ComplexRulesViewDataInteractor @Inject constructor(
4848
if (anyAction != null) {
4949
val hint = complexRuleViewDataMapper.mapActionTitle(
5050
action = anyAction,
51-
disallowOnlyPrevious = false
51+
disallowOnlyPrevious = false,
5252
)
5353
result += HintViewData(hint)
5454
}

features/feature_widget/src/main/java/com/example/util/simpletimetracker/feature_widget/grid/WidgetGridRemoveViewsFactory.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,6 @@ class WidgetGridRemoveViewsFactory @Inject constructor(
202202

203203
// TODO WIDGET:
204204
// TODO add settings activity to select number of cards
205-
// TODO add settings to filter some activities
206205
// TODO add settings for padding between cards?
207206
// TODO add repeat
208207
private fun getView(

resources/src/main/res/values-ar/strings.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -217,6 +217,7 @@
217217
<string name="complex_rules_hint">يسمح بتطبيق أكثر دقة لبعض الإعدادات</string>
218218
<string name="complex_rules_disable">إبطال</string>
219219
<string name="complex_rules_enable">يُمكَِن</string>
220+
<string name="complex_rules_action_disallow_only_previous_detail">السابق فقط</string>
220221

221222
<!-- Change complex rules -->
222223
<string name="change_complex_actions_title">فعل</string>
@@ -225,6 +226,7 @@
225226
<string name="change_complex_conditions_title">شروط</string>
226227
<string name="change_complex_starting_activity">نشاط البداية</string>
227228
<string name="change_complex_previous_activity">النشاط السابق</string>
229+
<string name="change_complex_disallow_only_previous">إيقاف الأنشطة المحددة فقط</string>
228230
<string name="change_complex_rule_removed">تمت إزالة القاعدة</string>
229231
<string name="change_complex_rule_choose_action">اختر الإجراء</string>
230232
<string name="change_complex_rule_choose_condition">اختر الشروط</string>

resources/src/main/res/values-ca/strings.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -217,6 +217,7 @@ Això et permet veure quant de temps dediques a activitats productives versus no
217217
<string name="complex_rules_hint">Permet una aplicació més afinada d\'alguns paràmetres</string>
218218
<string name="complex_rules_disable">Desactivar</string>
219219
<string name="complex_rules_enable">Activa</string>
220+
<string name="complex_rules_action_disallow_only_previous_detail">Només l\'anterior</string>
220221

221222
<!-- Change complex rules -->
222223
<string name="change_complex_actions_title">Acció</string>
@@ -225,6 +226,7 @@ Això et permet veure quant de temps dediques a activitats productives versus no
225226
<string name="change_complex_conditions_title">Condicions</string>
226227
<string name="change_complex_starting_activity">L\'activitat inicial</string>
227228
<string name="change_complex_previous_activity">Activitat prèvia</string>
229+
<string name="change_complex_disallow_only_previous">Només atura les activitats seleccionades</string>
228230
<string name="change_complex_rule_removed">Regla eliminada</string>
229231
<string name="change_complex_rule_choose_action">Trieu l\'acció</string>
230232
<string name="change_complex_rule_choose_condition">Trieu condicions</string>

resources/src/main/res/values-de/strings.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -217,6 +217,7 @@ Dies ermöglicht es dir, zu sehen, wie viel Zeit du insgesamt für produktive ve
217217
<string name="complex_rules_hint">Ermöglicht eine genauere Anwendung einiger Einstellungen</string>
218218
<string name="complex_rules_disable">Deaktivieren</string>
219219
<string name="complex_rules_enable">Aktivieren</string>
220+
<string name="complex_rules_action_disallow_only_previous_detail">Nur vorherige</string>
220221

221222
<!-- Change complex rules -->
222223
<string name="change_complex_actions_title">Aktion</string>
@@ -225,6 +226,7 @@ Dies ermöglicht es dir, zu sehen, wie viel Zeit du insgesamt für produktive ve
225226
<string name="change_complex_conditions_title">Bedingungen</string>
226227
<string name="change_complex_starting_activity">Die Startaktivität</string>
227228
<string name="change_complex_previous_activity">Vorherige Aktivität</string>
229+
<string name="change_complex_disallow_only_previous">Nur ausgewählte Aktivitäten stoppen</string>
228230
<string name="change_complex_rule_removed">Regel entfernt</string>
229231
<string name="change_complex_rule_choose_action">Aktion wählen</string>
230232
<string name="change_complex_rule_choose_condition">Wählen Sie Bedingungen</string>

0 commit comments

Comments
 (0)